Date: Fri, 7 Aug 2009 12:31:45 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 167088 for review Message-ID: <200908071231.n77CVjEY017007@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=167088 Change 167088 by hselasky@hselasky_laptop001 on 2009/08/07 12:31:04 USB CORE: - patch to fix busdma sync flag usage on ARM and PowerPC - patch was made by Grzegorz Bernacki & more @semihalf.com Affected files ... .. //depot/projects/usb/src/sys/dev/usb/usb_busdma.c#15 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/usb_busdma.c#15 (text+ko) ==== @@ -679,8 +679,14 @@ /* nothing has been loaded into this page cache! */ return; } - bus_dmamap_sync(pc->tag, pc->map, - BUS_DMASYNC_POSTWRITE | BUS_DMASYNC_POSTREAD); + + /* + * TODO: We currently do XXX_POSTREAD and XXX_PREREAD at the + * same time, but in the future we should try to isolate the + * differen cases to optimise the code. --HPS + */ + bus_dmamap_sync(pc->tag, pc->map, BUS_DMASYNC_POSTREAD); + bus_dmamap_sync(pc->tag, pc->map, BUS_DMASYNC_PREREAD); } /*------------------------------------------------------------------------* @@ -693,8 +699,7 @@ /* nothing has been loaded into this page cache! */ return; } - bus_dmamap_sync(pc->tag, pc->map, - BUS_DMASYNC_PREWRITE | BUS_DMASYNC_PREREAD); + bus_dmamap_sync(pc->tag, pc->map, BUS_DMASYNC_PREWRITE); } /*------------------------------------------------------------------------*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908071231.n77CVjEY017007>