Date: Tue, 01 Dec 2015 22:35:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 204943] usr/src/sbin/newfs_msdos/mkfs_msdos.c:586: memory leak ? Message-ID: <bug-204943-8-avVW8g1zCa@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204943-8@https.bugs.freebsd.org/bugzilla/> References: <bug-204943-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204943 Jilles Tjoelker <jilles@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jilles@FreeBSD.org --- Comment #2 from Jilles Tjoelker <jilles@FreeBSD.org> --- Although this fix is not wrong as such, fixing the memory leak in this extremely rare error case does not make much sense if the happy path and error cases that may actually happen still leak the memory. Note that this memory leak is only a problem if the code in newfs_msdos.c is changed so it does not exit immediately after mkfs_msdos() returns, or for static analyzers. The error from sigaction() could also be ignored (silently or loudly), reducing the code size, since a SIGINFO handler is not strictly required for creating a filesystem. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204943-8-avVW8g1zCa>