Date: Tue, 18 Sep 2018 14:00:45 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r480024 - head/multimedia/libx264 Message-ID: <201809181400.w8IE0jtH041477@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste (src committer) Date: Tue Sep 18 14:00:44 2018 New Revision: 480024 URL: https://svnweb.freebsd.org/changeset/ports/480024 Log: multimedia/libx264: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_PC32 against symbol: gettimeofday in readonly segment; recompile object files with -fPIC This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. PR: 214864, 230214 Reviewed by: koobs Approved by: koobs Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17201 Modified: head/multimedia/libx264/Makefile Modified: head/multimedia/libx264/Makefile ============================================================================== --- head/multimedia/libx264/Makefile Tue Sep 18 13:57:03 2018 (r480023) +++ head/multimedia/libx264/Makefile Tue Sep 18 14:00:44 2018 (r480024) @@ -14,6 +14,9 @@ LIB_DEPENDS= # USES= pathfix +LDFLAGS+= ${LDFLAGS_${ARCH}} +LDFLAGS_i386= -Wl,-znotext + OPTIONS_DEFINE= ASM OPENCL OPTIONS_DEFAULT= ASM OPENCL OPTIONS_EXCLUDE= FFMS GPAC LAVF LSMASH SWSCALE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809181400.w8IE0jtH041477>