Date: Thu, 18 Feb 2016 16:02:14 -0800 From: Maxim Sobolev <sobomax@FreeBSD.org> To: ray@freebsd.org, Adrian Chadd <adrian.chadd@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress Message-ID: <CAH7qZfvjRNKG7TA-qjPRU962EdxKiKbBS%2BkDPCjiFbNWzWdmig@mail.gmail.com> In-Reply-To: <CAH7qZfuOzAXzmmCBXGr3YcUeJgt420NE%2Bq9E-Xx6GVsoAYk_UA@mail.gmail.com> References: <CAH7qZfuOzAXzmmCBXGr3YcUeJgt420NE%2Bq9E-Xx6GVsoAYk_UA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
And also geom_uncompress(4) lists myself as a primary historical author of the kernel module code, which I think just plain confusion between my name and name of Max Khon, who is the original creator of geom_uzip(4). It's further reiterates the need to clean this up properly, so only the code with longer history survives. On Thu, Feb 18, 2016 at 3:57 PM, Maxim Sobolev <sobomax@freebsd.org> wrote: > Aleksandr, Adrian, > > I know it's 3 years later, but I really don't know why it's been done this > way. Take a GEOM module and associated usr.bin utility, copy it verbatim > add few lines of code and re-add that as a new module seems like just > laziness and attempt to avoid doing extra work on making unified code. The > same goes for the mkulzma, which is almost 1:1 copy of the mkuzip. Now > people are merging back and forth and I've just spent few days testing some > rather major rework of geom_uzip / mkuzip code not even realizing that > there is its evil twin in the tree. :( > > https://reviews.freebsd.org/D5333 > > I suggest functionality from both geom_uncompress / mkulzma are folded now > back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked > afterwards. > > Thanks! > > > >> Author: ray >> Date: Wed Jan 4 23:39:11 2012 >> New Revision: 229537 >> URL: http://svn.freebsd.org/changeset/base/229537 >> Log: >> GEOM_UNCOMPRESS module, can be used with uzip images and with new ulzma >> images. >> Approved by: adrian (mentor) >> Added: >> head/sys/geom/uncompress/ >> head/sys/geom/uncompress/g_uncompress.c (contents, props changed) >> head/sys/modules/geom/geom_uncompress/ >> head/sys/modules/geom/geom_uncompress/Makefile (contents, props changed) >> Modified: >> head/sys/conf/files >> head/sys/conf/options > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAH7qZfvjRNKG7TA-qjPRU962EdxKiKbBS%2BkDPCjiFbNWzWdmig>