Date: Sun, 13 Oct 2013 11:08:29 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Mark R V Murray <mark@grondar.org> Cc: Konstantin Belousov <kostikbel@gmail.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ian Lepore <ian@freebsd.org> Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... Message-ID: <CAJ-Vmom8A2oTCcLriP8vHG3M8pfQ0uPgBaQoeR9wDTCKedoT6w@mail.gmail.com> In-Reply-To: <6E7CF22B-B83B-4F31-955D-DC64441FAC8D@grondar.org> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> <20131013151359.GR41229@kib.kiev.ua> <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> <1381681119.42859.33.camel@revolution.hippie.lan> <6E7CF22B-B83B-4F31-955D-DC64441FAC8D@grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Mark, Can we make the VFS random seeding stuff a compile time option, so we can disable it for the embedded platforms where we'll never use it? Thanks, -adrian On 13 October 2013 10:03, Mark R V Murray <mark@grondar.org> wrote: > > On 13 Oct 2013, at 17:18, Ian Lepore <ian@FreeBSD.org> wrote: > > > On Sun, 2013-10-13 at 16:18 +0100, Mark R V Murray wrote: > >> On 13 Oct 2013, at 16:13, Konstantin Belousov <kostikbel@gmail.com> > wrote: > >>> Surely this works, thank you. The rwfile.c content probably should be > >>> taken under the #ifdef RANDOM_RWFILE. > >> > >> OK - thanks for the feedback! > >> > >>> But I do not see much use for the randomdev_read_file() and > >>> randomdev_write_file() functions. It would be better to directly code > >>> the VFS calls in the random_harvestq_cache(). For one thing, it would > >>> eliminate unneccessary close and open of the entropy file. > >> > >> There is some uncertainty about the future of that code, so I want > >> to keep it that way for now. Writing files from the kernel is making so@ > >> very uncomfortable, and there is too much scope for error there. > >> > > > > Indeed, it makes me nervous too, as a heavy user of readonly root > > filesystems. If writing this file is so critical that it has to be done > > by the kernel, then what happens when it fails? Right now it prints an > > error and continues -- if it is not so critical that failure means > > panic, then why is the kernel doing it at all? > > Good points all. The intent is not to win the arms-race outright, but to > win the common-case battles as convincingly as possible. That said, its > not looking good for the process, but I still want to give it a decent > look before/if yanking it. > > > Why is the file even in the root filesystem? /var/db seems to be the > > right place for a transient file needed by the system. > > Because that appears to be the best place to put first-boot entropy from > sysinstall/bsdinstall. /var/db/entropy/... will also be used if possible; > watch this space. > > > Speaking of errors, that might include things like the current code > > calling vn_close() with the FREAD flag on a file open for writing. > > > Thanks :-( :-) > > M > -- > Mark R V Murray > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmom8A2oTCcLriP8vHG3M8pfQ0uPgBaQoeR9wDTCKedoT6w>