Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Aug 2015 02:07:57 -0700
From:      Peter Wemm <peter@wemm.org>
To:        svn-src-all@freebsd.org
Cc:        Konstantin Belousov <kib@freebsd.org>, src-committers@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r285967 - stable/10/sys/kern
Message-ID:  <15144036.GlIf25C7QW@overcee.wemm.org>
In-Reply-To: <201507281712.t6SHCfQE026689@repo.freebsd.org>
References:  <201507281712.t6SHCfQE026689@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--nextPart51377094.oKn2YAAcBO
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="us-ascii"

On Tuesday, July 28, 2015 05:12:41 PM Konstantin Belousov wrote:
> Author: kib
> Date: Tue Jul 28 17:12:41 2015
> New Revision: 285967
> URL: https://svnweb.freebsd.org/changeset/base/285967
>=20
> Log:
>   MFC r284956:
>   Do not calculate the stack's bottom address twice.

This is a bad MFC.  stack_addr is different for ia64 in 10.x and this b=
reaks=20
threading on ia64.    eg: ntpd crashes on startup in the cluster machin=
es.


> Modified:
>   stable/10/sys/kern/kern_exec.c
> Directory Properties:
>   stable/10/   (props changed)
>=20
> Modified: stable/10/sys/kern/kern_exec.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> =3D=3D --- stable/10/sys/kern/kern_exec.c=09Tue Jul 28 17:08:32 2015=09=
(r285966) +++
> stable/10/sys/kern/kern_exec.c=09Tue Jul 28 17:12:41 2015=09(r285967)=
 @@
> -1116,7 +1116,7 @@ exec_new_vmspace(imgp, sv)
>  =09 * process stack so we can check the stack rlimit.
>  =09 */
>  =09vmspace->vm_ssize =3D sgrowsiz >> PAGE_SHIFT;
> -=09vmspace->vm_maxsaddr =3D (char *)sv->sv_usrstack - ssiz;
> +=09vmspace->vm_maxsaddr =3D (char *)stack_addr;
>=20
>  =09return (0);
>  }
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org=
"

=2D-=20
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI=
6FJV
UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246
--nextPart51377094.oKn2YAAcBO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJVvd3tAAoJEDXWlwnsgJ4EgaIIAKJ3uqkp7HdN883XLA5SgUQU
gE7233tpMNUHOStkB0o1OT07CH/eLq40Py6LfBXPIC+DKXt7UZlZp2cdnzVgzBEK
S+B60Ct2drDK7P/0B2gHHzidP4d9KezYt2gs8+u9Z9iaJkbSsp1WKO90pO2PvaJT
0pvZDc00PERG7FYKm6bmK93xDdl+4JNGRJWF3z20nLXR2ex+pvrpucGtYVXlK2At
wkT/z9aclBeOF2iUTZRjjh9IwBzqRhF5F8vBUNEAaCULCAIovkFBe7qD/QHBLMUd
mIOWHxzf1vcgLzDPq4GGVe6YZr3WlvcLsE9JNO4RKg701al/n8xoWvPBQmaI6LQ=
=IyRt
-----END PGP SIGNATURE-----

--nextPart51377094.oKn2YAAcBO--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15144036.GlIf25C7QW>