Date: Sun, 21 Mar 2004 20:32:39 +0100 (CET) From: Simon Barner <barner@in.tum.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: roddie@krweb.net Subject: ports/64545: audio/easytag: Fix memory leak Message-ID: <20040321193239.E653647AA@zi025.glhnet.mhn.de> Resent-Message-ID: <200403211940.i2LJeDkY022711@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 64545
>Category: ports
>Synopsis: audio/easytag: Fix memory leak
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Mar 21 11:40:12 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Simon Barner
>Release: FreeBSD 4.9 i386
>Organization:
>Environment:
System: FreeBSD zi025.glhnet.mhn.de 4.9-STABLE FreeBSD 4.9-STABLE #0: Tue Feb 10 01:57:14 CET 2004 simon@zi025.glhnet.mhn.de:/usr/src/sys/compile/KISTE i386
>Description:
Easytag leaks memory in the file list GTK control. The attached patch
from the author addresses this problem, but there is still _another_
memory leak around. I have informed the author about that, and I will
report back as soon as I hear from him (he seems to be very responsive).
>How-To-Repeat:
(This description is for the remaining bug, but it should be good enough
to make the problem clear)
- Make sure the "Tag and File Name scan" Window is open, and that
"Fill Tag" is selected.
- Choose an mp3 folder and enter a regular expression that does _not_
match the files in that folder, and that has a place holder after the
mismatched separator (see below for an example).
- Move the selection in the mp3 list up and down => the memory usage
increases continuously.
>Fix:
(There is still one more fix to come!)
--- patch-src_browser_c begins here ---
--- src/browser.c.orig Thu Feb 12 00:14:57 2004
+++ src/browser.c Sun Mar 21 18:22:21 2004
@@ -918,6 +918,7 @@
style->base[GTK_STATE_NORMAL] = LIGHT_BLUE;
}
gtk_clist_set_row_style(GTK_CLIST(BrowserList),row,style);
+ gtk_style_unref(style);
}
--- patch-src_browser_c ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040321193239.E653647AA>