Date: Thu, 13 Sep 2001 10:38:52 +0100 From: David Malone <dwmalone@maths.tcd.ie> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Ruslan Ermilov <ru@FreeBSD.org>, David Malone <dwmalone@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c Message-ID: <200109131038.aa29881@salmon.maths.tcd.ie> In-Reply-To: Your message of "13 Sep 2001 08:28:19 %2B0200." <xzpadzzy58c.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
> Ruslan Ermilov <ru@FreeBSD.org> writes: > > Hmm, don't you broke the `-hostname' and `#-hostname' syntaxes with > > your commit? > Yes, I apparently broke something that didn't work to begin with. And > the patch you posted in a followup to the PR doesn't compile, and > fails to take into accound at least two different (fully valid) cases. The old code worked almost fine. If syslog logs a line saying: Sep 13 09:44:50 walton login: login from beta on ttyp8 as gary then this line can be selected on by using "+walton" or rejected using "-walton". I explained this to the submitter of the PR and he was happy with this explaination and conculded his analysis wasn't correct. The only time that this does not work as expected is if you say "+walton.maths.tcd.ie" (which is walton's full host name). Then this line will not be selected, which may be unexpected. The correct fix is to make syslogd use the FQDN all the time internally and only trim the local domain name before printing. At the moment it trims host names almost immediately before looking them up. I've looked into this and it shouldn't be too hard to impliment a fix. I left the PR open until I have time to fix this. If you decided to impliment another fix please make sure it is not going to have unexpected effects for people already using this feture. I'd be happy to review any patch you suggest. Can I give you the pointy hat back now? ;-) David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200109131038.aa29881>