Date: Mon, 16 Apr 2018 08:31:47 -0400 From: Adriaan de Groot <adridg@freebsd.org> To: "Lev A. Serebryakov" <lev@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467478 - in head: devel/p5-subversion devel/py-subversion devel/ruby-subversion devel/subversion devel/subversion/files java/java-subversion www/mod_dav_svn Message-ID: <22429616.yAmutGOGha@a-pc> In-Reply-To: <201804161153.w3GBr3HW062183@repo.freebsd.org> References: <201804161153.w3GBr3HW062183@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1857805.W36H4VL4gu
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Hi Lev,
On Monday, April 16, 2018 7:53:03 AM EDT Lev A. Serebryakov wrote:
> Modified: head/devel/p5-subversion/Makefile
> ============================================================================
> == --- head/devel/p5-subversion/Makefile Mon Apr 16 11:18:24 2018
> (r467477) +++ head/devel/p5-subversion/Makefile Mon Apr 16 11:53:03 2018
> (r467478) @@ -2,7 +2,7 @@
> # $FreeBSD$
>
> PKGNAMEPREFIX= p5-
> -PORTREVISION= 2
> +PORTREVISION= 0
It's a bit unusual to leave PORTREVISION in the Makefile when it's 0, isn't
it? It doesn't really reduce churn, either, in the line-based diffs subversion
supports.
> MAINTAINER= lev@FreeBSD.org
> COMMENT= Perl bindings for Version control system
> @@ -32,6 +32,9 @@ CONFIGURE_ARGS+= --without-gnome-keyring \
>
> ALL_TARGET= swig-pl-lib swig-pl
> INSTALL_TARGET= install-swig-pl
> +
> +#CPPFLAGS+= -I${LOCALBASE}/lib/perl5/${PERL_VER}/${PERL_ARCH}/CORE \
> +# -Isubversion/bindings/swig/proxy
It's also unusual to leave commented out bits-n-bobs from previous versions
around; that's what subversion is for :)
[ade]
--nextPart1857805.W36H4VL4gu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iF4EABEIAAYFAlrUl7MACgkQMu5UWj4IU09kNQEAzcn9pgK5+5FqdWPWDU800OPk
npBLo7il6V+ERY24N4AA/3MWrLp3c0rZBTnqNlHB4j2dZ58YlHZNA0bqyL2GQf1l
=xA0g
-----END PGP SIGNATURE-----
--nextPart1857805.W36H4VL4gu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22429616.yAmutGOGha>