Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jan 2008 01:49:40 GMT
From:      John Birrell <jb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 132936 for review
Message-ID:  <200801100149.m0A1nelP005994@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=132936

Change 132936 by jb@jb_freebsd1 on 2008/01/10 01:49:17

	Enable the toxic range additions.
	
	Now that we have a DTrace probe safe printf() call (enabled if built
	with DEBUG mode enabled), lets log attempts to write to toxic addresses.

Affected files ...

.. //depot/projects/dtrace/src/sys/contrib/opensolaris/uts/common/dtrace/dtrace.c#15 edit

Differences ...

==== //depot/projects/dtrace/src/sys/contrib/opensolaris/uts/common/dtrace/dtrace.c#15 (text) ====

@@ -481,6 +481,7 @@
 									\
 		if (addr + size <= dtrace_toxrange[i].dtt_base)		\
 			continue;					\
+dtrace_debug_printf("%s: 0x%lx <= addr 0x%lx <= 0x%lx\n", __func__,(u_long) dtrace_toxrange[i].dtt_base,(u_long) addr,(u_long) dtrace_toxrange[i].dtt_limit); \
 									\
 		/*							\
 		 * This address falls within a toxic region; return 0.	\
@@ -14559,8 +14560,6 @@
 static void
 dtrace_toxrange_add(uintptr_t base, uintptr_t limit)
 {
-printf("%s(%d): DOODAD\n",__func__,__LINE__);
-#ifdef DOODAD
 	if (dtrace_toxranges >= dtrace_toxranges_max) {
 		int osize, nsize;
 		dtrace_toxrange_t *range;
@@ -14593,7 +14592,6 @@
 	dtrace_toxrange[dtrace_toxranges].dtt_base = base;
 	dtrace_toxrange[dtrace_toxranges].dtt_limit = limit;
 	dtrace_toxranges++;
-#endif
 }
 
 /*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801100149.m0A1nelP005994>