Date: Thu, 18 Nov 2004 09:20:31 GMT From: "Volker Stolz" <vs@freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/74033: New port: devel/log4cplus C++ logging API, similar to log4j Message-ID: <200411180920.iAI9KVR4089904@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/74033; it has been noted by GNATS.
From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, petri.totterman@hmv.fi
Cc:
Subject: Re: ports/74033: New port: devel/log4cplus C++ logging API, similar to log4j
Date: Thu, 18 Nov 2004 10:12:33 +0100
- The correct way for setting pthread-related flags is:
CONFIGURE_ENV+= CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" \
LDFLAGS="${LDFLAGS} ${PTHREAD_LIBS}"
- You do not install any documentation (must be doxygen'ed?)
- Especially, please check if you're violating the Apache Software
License, sec.2 when generating the binary package!
- You must use Tabs, not spaces in the Makefile
- portlint emmitted a warning for pkg-descr
- It's probably overkill to list email-addresses in pkg-descr
- Configuring yields:
===> Configuring for log4cplus-1.0.2
configure: WARNING: you should use --build, --host, --target
checking for a BSD-compatible install... /usr/bin/install -c -o root -g
wheel
checking whether build environment is sane... yes
/usr/home/stolz/log4cplus/work/log4cplus-1.0.2/missing: Unknown `--run'
option
Try `/usr/home/stolz/log4cplus/work/log4cplus-1.0.2/missing --help' for
more information
configure: WARNING: `missing' script is too old or missing
Is this a problem?
- The included libtool-version is 1.5. Although I can't spot any important
differences in the build, you might consider setting LIBTOOL_VER to 15
instead.
- GNU Make is not required
- GNU_CONFIGURE is redundant in the presence of USE_LIBTOOL_VER.
Please review these suggestion. Do not yet submit an updated PR or patch!
Cheers,
Volker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411180920.iAI9KVR4089904>