Date: Sun, 5 Jun 2011 19:17:53 +0100 From: Chris Rees <utisoft@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/157630: [PATCH] Fix port: net/yate-devel should use USERS Message-ID: <BLU0-SMTP1520A03F868A352A64D6FC3A9610@phx.gbl> Resent-Message-ID: <201106051820.p55IK5Pw074726@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157630
>Category: ports
>Synopsis: [PATCH] Fix port: net/yate-devel should use USERS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Jun 05 18:20:05 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Chris Rees
>Release: FreeBSD 8.2-RELEASE-p1 i386
>Organization:
bayofrum
>Environment:
System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386
>Description:
This port uses pkg-install to create new users instead of using USERS= and GROUPS=
XXXXXXXXXX
Because it's marked BROKEN, I haven't Tinderbox checked it. Balwinder, please would you incorporate this patch into your fix?
XXXXXXXXXX
>How-To-Repeat:
>Fix:
- Use USERS and GROUPS
Submitted by: Chris Rees (utisoft@gmail.com)
--- yate-devel.patch begins here ---
Index: Makefile
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/net/yate-devel/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- Makefile 20 Jan 2011 17:38:16 -0000 1.16
+++ Makefile 31 May 2011 19:37:36 -0000
@@ -47,6 +47,8 @@
H323 "H323 software channel/protocol support" on \
FAX "Fax software channel/driver support" off
+USERS= ${PORTNAME}
+GROUPS= ${USERS}
DOCSDIR= ${LOCALBASE}/share/doc/yate
PLIST_SUB= BRISTUFF="@comment "
PLIST_SUB+= VERSION=${PORTVERSION:S/.p2//}
Index: pkg-install
===================================================================
RCS file: pkg-install
diff -N pkg-install
--- pkg-install 23 Sep 2007 12:34:40 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,35 +0,0 @@
-#!/bin/sh
-# $FreeBSD: ports/net/yate-devel/pkg-install,v 1.1 2007/09/23 12:34:40 edwin Exp $
-#
-
-if [ "$2" != "PRE-INSTALL" ]; then
- exit 0
-fi
-
-YATE_USER=yate
-YATE_GROUP=${YATE_USER}
-YATE_UID=204
-YATE_GID=${YATE_UID}
-
-if ! pw groupshow "${YATE_GROUP}" 2>/dev/null 1>&2; then
- if pw groupadd ${YATE_GROUP} -g ${YATE_GID}; then
- echo "Added group \"${YATE_GROUP}\"."
- else
- echo "Adding group \"${YATE_GROUP}\" failed..."
- exit 1
- fi
-fi
-
-if ! pw usershow "${YATE_USER}" 2>/dev/null 1>&2; then
- if pw useradd ${YATE_USER} -u ${YATE_UID} -g ${YATE_GROUP} -h - \
- -s "/sbin/nologin" -d "/nonexistent" \
- -c "Yate Telephoney Server"; \
- then
- echo "Added user \"${YATE_USER}\"."
- else
- echo "Adding user \"${YATE_USER}\" failed..."
- exit 1
- fi
-fi
-
-exit 0
--- yate-devel.patch ends here ---
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BLU0-SMTP1520A03F868A352A64D6FC3A9610>