Date: Mon, 10 Jul 2006 20:22:12 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-current@freebsd.org Cc: Martin Blapp <mb@imp.ch> Subject: Re: Please help reviewing ! Got another crash because of the ttymodem() / ttyclose() race Message-ID: <200607102022.12919.jhb@freebsd.org> In-Reply-To: <20060708084356.R14714@godot.imp.ch> References: <20060708020700.A14714@godot.imp.ch> <20060708081419.W14714@godot.imp.ch> <20060708084356.R14714@godot.imp.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 08 July 2006 02:44, Martin Blapp wrote: > > > > Ok, fixed. Does it look better now ? > > > > here's the link again. > > http://mx.imp.ch/patches/patch-tty.t_pgrp.diff You can't lock tp->t_pgrp before you check it for NULL! Seriously, the solution is to make sure Giant is held everywhere that t_pgrp is accessed for now. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607102022.12919.jhb>