Date: Mon, 2 Jun 2014 22:15:12 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: multimedia@FreeBSD.org Subject: Re: [review/test] multimedia/vlc: various fixes Message-ID: <20140602201511.GA45150@ivaldir.etoilebsd.net> In-Reply-To: <20140601232335.3d175beb@kalimero.tijl.coosemans.org> References: <20140601232335.3d175beb@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--x+6KMIRAuhnl3hBn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Jun 01, 2014 at 11:23:35PM +0200, Tijl Coosemans wrote:
> Hi,
>=20
> Please check out the attached patch for multimedia/vlc. It contains the
> following changes:
>=20
> - Remove libproxy dependency. I cannot find any references to it.
> - Add libidn dependency. It is always picked up when detected by
> configure.
> - Add libxml2 dependency (USE_GNOME=3Dlibxml2). It's actually an optional
> dependency but it is used by several other plugins.
> - Replace OSVERSION+clang tests with USES=3Dcompiler:c11.
> - Replace post-patch command with USES=3Dpathfix.
> - Add some more --enable-* flags to CONFIGURE_ARGS to make sure configure
> doesn't silently ignore problems with dependencies.
> - Add some more --disable-* flags to CONFIGURE_ARGS to make sure
> configure doesn't auto-enable them.
> - Specify the correct location of KDE Solid files in CONFIGURE_ARGS.
> ("Play with VLC" option when you insert a CD/DVD.)
> - Add ac_cv_search_pthread_rwlock_init=3D-pthread to CONFIGURE_ARGS to
> override the test for libpthread. It detects pthread_rwlock_init in
> our libc and assumes no threading library is needed, but libc doesn't
> have a real pthread implementation.
> - Add the gnutls3 include directory to CPPFLAGS before LOCALBASE/include
> which may contain gnutls2 headers.
> - Rename some options so more descriptions from bsd.options.desc.mk can
> be used.
> - Add OPTIMIZED_CFLAGS to OPTIONS_DEFAULT. Remove custom CFLAGS so this
> option only controls the "optimizations" configure option which is
> enabled by default by upstream.
> - Remove REALAUDIO from OPTIONS_DEFAULT. Old codec.
> - Remove SDL from OPTIONS_DEFAULT. This is an alternative way to render
> video. The X11 option is better for this.
> - Remove SKINS from OPTIONS_DEFAULT.
> - Remove X264 from OPTIONS_DEFAULT. It's an encoder, not a decoder and
> vlc is typically used as a player not as a video server.
> - Remove SERVER_ONLY and NO_DVD options. Their implementation doesn't
> work with modern options framework.
> - Add a patch to fix some issues in the configure script, e.g. don't add
> -L/usr/local/lib to LDFLAGS. This ends up in the wrong place on the
> linker command line causing installed vlc libraries to be linked in
> instead of freshly built ones.
> - With patched configure some options like A52 need include/library
> search paths now.
> - Some options have pkgconfig files now so remove include/library search
> paths where possible.
> - Separate KATE option from OGG.
> - Use option helpers for LIBRSVG2, LUA, OGG, QT4, SDL, V4L and X11.
> - Implement NCURSES option with USES=3Dncurses.
> - Add VDPAU option.
> - Drop perl5 dependency.
> - Drop old hacks like -fPIC, -I${WRKSRC}/include, LIBS=3D"-lc", PTHREAD_L=
IBS.
> - Add missing dependencies to SKINS option (libminizip, xorg)
> - Patch the right file with WITH_CDROM_DEVICE and WITH_DVD_DEVICE.
> - Only use auto-plist for the plugins directory. Use regular pkg-plist,
> PORTDATA and PORTDOCS for everything else. This is a lot simpler and
> makes it easier to detect library version changes.
> - Delete some unneeded patches.
>=20
> Redports test with all options enabled:
> https://redports.org/buildarchive/20140601173701-19671/
> https://redports.org/buildarchive/20140601181106-57163/
> (FreeBSD 8.4 is still broken for some combinations of options due to a
> bug in rtld there.)
Approved
bapt
--x+6KMIRAuhnl3hBn
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iEYEARECAAYFAlOM208ACgkQ8kTtMUmk6EyFXACgksLfRzA91EnVjXaCWIZVbR61
F7sAnAxN2jdxxnkeOT0MlXMCTmbcf3UW
=BDxC
-----END PGP SIGNATURE-----
--x+6KMIRAuhnl3hBn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140602201511.GA45150>