Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Apr 2018 17:30:27 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 227779] net/chrony: Update to 3.3
Message-ID:  <bug-227779-7788-6a4cPgEhsY@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-227779-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-227779-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227779

--- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> ---
+IPV6_CONFIGURE_ON=3D     --disable-readline

Why does enabling IPV6 require one to disable readline support? This
makes little immediate sense.

+do-build:
+.for file in ${PORTEXAMPLES}
+       @${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/examples/${file}
+.endfor

This seems wrong:

a) do-build is being overwritten, which means that if chrony is built at all
   it would happen in the wrong phase (probably stage) by accident.
b) _SUB_LIST_TEMP is a private variable. I assume this is about the
   aforementioned %%PREFIX%% fix.  If so just make an explicit
   substitution instead.

Since this port uses PORTDOCS and PORTEXAMPLES adding explicit DOCS and
EXAMPLES options would be a good idea too.

+.if ${ARCH} =3D=3D armv6 || ${ARCH} =3D=3D armv7
+EXTRA_PATCHES=3D         ${FILESDIR}/extra-util.c
+.endif

Why is this only needed on armv{6,7} now? It was applied on all
archs before. Leave a comment about this in the patch file header.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227779-7788-6a4cPgEhsY>