Date: Mon, 1 Jul 2019 07:34:49 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Larry Rosenman <ler@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505444 - head/sysutils/lsof Message-ID: <20190701073449.GA76737@FreeBSD.org> In-Reply-To: <201906301915.x5UJFU4J074561@repo.freebsd.org> References: <201906301915.x5UJFU4J074561@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 30, 2019 at 07:15:30PM +0000, Larry Rosenman wrote: > New Revision: 505444 > URL: https://svnweb.freebsd.org/changeset/ports/505444 > > Log: > sysutils/lsof: quiet portlint. This is very bad commit message, it explains nothing. Moreover, appealing to portling(1), blindly lihe this, is usually bogus and wrong. > Modified: head/sysutils/lsof/Makefile > @@ -31,7 +31,7 @@ CONFIGURE_ARGS= -n freebsd > CONFIGURE_ENV= LSOF_CC="${CC}" FREEBSD_SYS="${SRC_BASE}/sys" > > .if !exists(${SRC_BASE}/sys/kern/kern_lockf.c) > -IGNORE= requires kernel sources > +IGNORE+= requires kernel sources > .endif That said, could you explain the scenario (like, what make(1) commands and under what circumstances I must type) to demonstrate what was wrong here before and how did your commit fix it? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190701073449.GA76737>