Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Aug 2009 09:14:37 +0100 (BST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Hans Petter Selasky <hselasky@c2i.net>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein <alfred@freebsd.org>, src-committers@freebsd.org, Navdeep Parhar <nparhar@gmail.com>
Subject:   Re: svn commit: r195960 - in head/sys/dev/usb: . controller input (regression patch)
Message-ID:  <alpine.BSF.2.00.0908030909220.1507@fledge.watson.org>
In-Reply-To: <200908030923.12867.hselasky@c2i.net>
References:  <200908030923.12867.hselasky@c2i.net>

next in thread | previous in thread | raw e-mail | index | archive | help

On Mon, 3 Aug 2009, Hans Petter Selasky wrote:

> Here is a patch to address the problem. Please test and report back. Works 
> fine over here.
>
> http://perforce.freebsd.org/chv.cgi?CH=166957
>
> MD5 (ukbd.c.diff) = 1e3c143942593b0ed4617d306a9d2ee2
>
> cd /usr/src/sys/dev/usb/input/
> cat ukbd.c.diff | patch

I'm a bit surprised the timed key repeat in this patch would work properly in 
DDB, as microtime(9) relies on interrupts firing for updated timestamps.  The 
availability of interrupts for polled input consumers varies, but in general 
this is not true (for example) at the DDB command prompt.  Does this code work 
correctly when time stands still?

Robert N M Watson
Computer Laboratory
University of Cambridge



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0908030909220.1507>