Date: Thu, 8 Aug 2013 01:24:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Lars Thegler <lth@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r324346 - head/mail/p5-Email-MIME Message-ID: <20130808012434.GA88816@FreeBSD.org> In-Reply-To: <CAO7rfHFLFyYWMLHWmAsFdRQddWWVsaMgCvzoQDLdthwuhRKrrQ@mail.gmail.com> References: <201308071059.r77AxLsr062610@svn.freebsd.org> <20130807115151.GA86185@FreeBSD.org> <CAO7rfHFLFyYWMLHWmAsFdRQddWWVsaMgCvzoQDLdthwuhRKrrQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 07, 2013 at 07:09:58PM +0200, Lars Thegler wrote:
> On Wed, Aug 7, 2013 at 1:51 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Wed, Aug 07, 2013 at 10:59:21AM +0000, Lars Thegler wrote:
> >> -regression-test: build
> >> - @cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} test
> >
> > Commit log tells nothing about why regression-test target was removed.
>
> True. I still hope that someday swills' patch [1] will find its way
> in. Until such a time, this target is only really useful for the
> maintainer (me), and thus doesn't need to be in the port Makefile, in
> my opinion.
I was under impression that "regression-test" targets are commonly executed
by our build farms, as one little extra step to ensure package correctness.
Plus, maintainers tend to change, or your port might be used as an example
for someone else. It's nice to spread out knowledge about that tests can
be part of the Makefile. ;-)
I generally like these targets, as they do not affect normal users who build
things from ports, and presumably make packages better at the same time.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130808012434.GA88816>