Date: Fri, 16 Mar 2007 17:39:41 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: Volker <volker@vwsoft.com>, cvs-ports@FreeBSD.org, Andrey Alakozov <aa29@mail.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/apache13-modperl Makefile pkg-plist ports/www/apache13-modperl/files apache.in apache.sh Message-ID: <45FB38CD.90200@FreeBSD.org> In-Reply-To: <200703142021.l2EKLVr0024152@repoman.freebsd.org> References: <200703142021.l2EKLVr0024152@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik wrote: > pav 2007-03-14 20:21:31 UTC > > FreeBSD ports repository > > Modified files: > www/apache13-modperl Makefile pkg-plist > Added files: > www/apache13-modperl/files apache.in > Removed files: > www/apache13-modperl/files apache.sh > Log: > - Fix rc script to have overridable apache_flags and apache_pidfile > > PR: ports/104465 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=104465 > Reported by: Andrey Alakozov <aa29@mail.ru> > Submitted by: Volker <volker@vwsoft.com> > Approved by: maintainer timeout (apache; 5 months) > > - While here, modernize USE_RC_SUBR usage > > Revision Changes Path > 1.18 +2 -8 ports/www/apache13-modperl/Makefile > 1.1 +32 -0 ports/www/apache13-modperl/files/apache.in (new) > 1.4 +0 -32 ports/www/apache13-modperl/files/apache.sh (dead) > 1.7 +0 -1 ports/www/apache13-modperl/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/Makefile.diff?&r1=1.17&r2=1.18&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/files/apache.sh > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-modperl/pkg-plist.diff?&r1=1.6&r2=1.7&f=h The changes to the Makefile and plist look good, thanks! Two problems with the rc.d script though. First, this: apache_flags="${apache_flags=''}" Is not necessary, or desirable. Second, since httpd is going to run as user www, the BEFORE statement should be dropped, and the REQUIRE should be changed to LOGIN. I'm happy to make these changes if no one objects. Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45FB38CD.90200>