Date: Tue, 22 May 2018 00:35:22 -0700 From: Matthew Macy <mmacy@freebsd.org> To: Eitan Adler <lists@eitanadler.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333968 - in head/sys: netinet netinet6 Message-ID: <CAPrugNrJLd0FnMa-A0%2B9ucKFE0WJZZYycpJzU8wyTfbRTBwHcA@mail.gmail.com> In-Reply-To: <CAF6rxg=0N3x%2B3KuxrS%2BsHtt6TxpN8Q8yMAAKjTT=ro3vyiyxJQ@mail.gmail.com> References: <201805210834.w4L8YAcD022948@repo.freebsd.org> <CAF6rxg=0N3x%2B3KuxrS%2BsHtt6TxpN8Q8yMAAKjTT=ro3vyiyxJQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 22, 2018 at 00:33 Eitan Adler <lists@eitanadler.com> wrote: > On 21 May 2018 at 01:34, Matt Macy <mmacy@freebsd.org> wrote: > > Author: mmacy > > Date: Mon May 21 08:34:10 2018 > > New Revision: 333968 > > URL: https://svnweb.freebsd.org/changeset/base/333968 > > > > Log: > > in(6)_mcast: Expand out vnet set / restore macro so that they work in > a conditional block > > Why not simply add missing {} s or modifying the macro to use "do { } > while(false)" ? > It declares variables which would go out of scope. > -- > Eitan Adler >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPrugNrJLd0FnMa-A0%2B9ucKFE0WJZZYycpJzU8wyTfbRTBwHcA>