Date: Wed, 2 Jul 2008 21:06:09 +0200 (CEST) From: Tobias Rehbein <tobias.rehbein@web.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/125194: [patch] games/tome package-building is broken Message-ID: <200807021906.m62J69vE011542@sushi.pseudo.local> Resent-Message-ID: <200807021910.m62JA30r074569@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 125194 >Category: ports >Synopsis: [patch] games/tome package-building is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 02 19:10:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Tobias Rehbein >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD sushi.pseudo.local 7.0-STABLE FreeBSD 7.0-STABLE #10: Sun Jun 29 16:01:51 CEST 2008 tobi@sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386 >Description: The package by make package will install fine but it's not possible to start the game. make install runs T.o.M.Es own install script which changes file permissions. This is not done using the binary package. To fix this I have added the corresponding @exec directives to the pkg-plist. While here I added the creation of the plot directory which is not part of the binary package. While here I replaced @dirrm with @dirrmtry directives to make the deinstall less verbose. Problem is T.o.M.E spams the %%DATADIR%% so it won't deinstall cleanly. To make the user aware of this I added a pkg-deinstall script which will emit a corresponding message. Regards Tobias >How-To-Repeat: Install T.o.M.E using binary package and try to start it. >Fix: --- tome.diff begins here --- diff -ruN games/tome.orig/Makefile games/tome/Makefile --- games/tome.orig/Makefile 2008-05-15 22:12:26.000000000 +0200 +++ games/tome/Makefile 2008-07-02 12:13:20.000000000 +0200 @@ -7,6 +7,7 @@ PORTNAME= tome PORTVERSION= 2.3.5 +PORTREVISION= 1 CATEGORIES= games MASTER_SITES= http://t-o-m-e.net/dl/src/ DISTNAME= tome-235-src @@ -14,6 +15,8 @@ MAINTAINER= peter.thoenen@yahoo.com COMMENT= Roguelike dungeon exploration game based on JRR Tolkien's works +SUB_FILES= pkg-deinstall + ALL_TARGET= # empty MAKEFILE= makefile.bsd USE_GMAKE= yes diff -ruN games/tome.orig/files/pkg-deinstall.in games/tome/files/pkg-deinstall.in --- games/tome.orig/files/pkg-deinstall.in 1970-01-01 01:00:00.000000000 +0100 +++ games/tome/files/pkg-deinstall.in 2008-07-02 12:06:15.000000000 +0200 @@ -0,0 +1,12 @@ +#!/bin/sh +# $FreeBSD$ + +if [ "$2" = "POST-DEINSTALL" ]; then + echo "" + echo "If you are removing T.o.M.E permanently you should run" + echo "the following command:" + echo "" + echo " rm -rf %%DATADIR%%" + echo "" +fi + diff -ruN games/tome.orig/pkg-plist games/tome/pkg-plist --- games/tome.orig/pkg-plist 2008-05-15 22:12:26.000000000 +0200 +++ games/tome/pkg-plist 2008-07-02 16:08:56.000000000 +0200 @@ -1,4 +1,6 @@ bin/tome +@exec chown root:games %F +@exec chmod 2755 %F %%DATADIR%%/apex/.cvsignore %%DATADIR%%/apex/delete.me %%DATADIR%%/apex/scores.raw @@ -446,27 +448,30 @@ %%DATADIR%%/xtra/music/delete.me %%DATADIR%%/xtra/sound/Sound.cfg %%DATADIR%%/xtra/sound/readme.txt -@dirrm %%DATADIR%%/xtra/sound -@dirrm %%DATADIR%%/xtra/music -@dirrm %%DATADIR%%/xtra/graf -@dirrm %%DATADIR%%/xtra/font -@dirrm %%DATADIR%%/xtra -@dirrm %%DATADIR%%/user -@dirrm %%DATADIR%%/scpt -@dirrm %%DATADIR%%/save -@dirrm %%DATADIR%%/pref -@dirrm %%DATADIR%%/plot -@dirrm %%DATADIR%%/patch -@dirrm %%DATADIR%%/note -@dirrm %%DATADIR%%/mods -@dirrm %%DATADIR%%/info -@dirrm %%DATADIR%%/help -@dirrm %%DATADIR%%/file -@dirrm %%DATADIR%%/edit -@dirrm %%DATADIR%%/dngn -@dirrm %%DATADIR%%/data -@dirrm %%DATADIR%%/core -@dirrm %%DATADIR%%/cmov -@dirrm %%DATADIR%%/bone -@dirrm %%DATADIR%%/apex -@dirrm %%DATADIR%% +@exec mkdir %D/%%DATADIR%%/plot +@exec chown -R root:games %D/%%DATADIR%% +@exec chmod -R g+w %D/%%DATADIR%% +@dirrmtry %%DATADIR%%/xtra/sound +@dirrmtry %%DATADIR%%/xtra/music +@dirrmtry %%DATADIR%%/xtra/graf +@dirrmtry %%DATADIR%%/xtra/font +@dirrmtry %%DATADIR%%/xtra +@dirrmtry %%DATADIR%%/user +@dirrmtry %%DATADIR%%/scpt +@dirrmtry %%DATADIR%%/save +@dirrmtry %%DATADIR%%/pref +@dirrmtry %%DATADIR%%/plot +@dirrmtry %%DATADIR%%/patch +@dirrmtry %%DATADIR%%/note +@dirrmtry %%DATADIR%%/mods +@dirrmtry %%DATADIR%%/info +@dirrmtry %%DATADIR%%/help +@dirrmtry %%DATADIR%%/file +@dirrmtry %%DATADIR%%/edit +@dirrmtry %%DATADIR%%/dngn +@dirrmtry %%DATADIR%%/data +@dirrmtry %%DATADIR%%/core +@dirrmtry %%DATADIR%%/cmov +@dirrmtry %%DATADIR%%/bone +@dirrmtry %%DATADIR%%/apex +@dirrmtry %%DATADIR%% --- tome.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807021906.m62J69vE011542>