Date: Sat, 02 Dec 2000 17:01:05 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Bosko Milekic <bmilekic@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <XFMail.001202170105.jhb@FreeBSD.org> In-Reply-To: <200012020040.eB20ew884237@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02-Dec-2000 Bosko Milekic wrote: > bmilekic 2000/12/01 16:40:57 PST > > Modified files: > sys/kern uipc_syscalls.c > Log: > Make sure to free the sf_buf if we've allocated it but fail to allocate > an mbuf (ENOBUFS) before returning so that we don't leak sf_bufs in > the case where we're out of mbufs. > > Submitted by: David Greenman (dg) Should the second argument be NULL rather than PAGE_SIZE to sf_buf_free()? ../../kern/uipc_syscalls.c: In function `sendfile': ../../kern/uipc_syscalls.c:1708: warning: passing arg 2 of `sf_buf_free' makes pointer from integer without a cast From my reading, the args parameter isn't even used by sf_buf_free()... -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001202170105.jhb>