Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Aug 2010 16:51:49 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        cvs-ports@freebsd.org, Thomas Abthorpe <tabthorpe@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/www/fcgiwrap Makefile ports/www/fcgiwrap/files fcgiwrap.in
Message-ID:  <4C6F1515.7090708@FreeBSD.org>
In-Reply-To: <AANLkTikHR3Ug5hqvV3nzpuGc%2BLWSz9Qv577R=6aViEC2@mail.gmail.com>
References:  <201008171940.o7HJebDf077588@repoman.freebsd.org>	<4C6D8DBF.8070308@FreeBSD.org> <AANLkTikHR3Ug5hqvV3nzpuGc%2BLWSz9Qv577R=6aViEC2@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 08/20/2010 01:55, Baptiste Daroussin wrote:
> 2010/8/19 Doug Barton<dougb@freebsd.org>:
>> This is a very nice looking script, well done! The only problem is that
>> _flags should not be added to command_args, it will cause them to be added
>> twice since rc.subr already takes care of this.
>>
>>
>> Doug
>
> thanks.
>
> Concerning the _flags I'll make the change.

Excellent. :)

> by the way, the method I use to cleanup trailing unix sockets do you
> think that it is clean? or I should find a better way?

Not off hand, no. You might want to contact the upstream authors about 
this issue, it's not very friendly of them to leave sockets laying 
around ...


Doug

-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

	Computers are useless. They can only give you answers.
			-- Pablo Picasso




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C6F1515.7090708>