Date: Wed, 15 Jul 2020 01:56:22 -0600 From: Adam Weinberger <adamw@adamw.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Adam Weinberger <adamw@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r542249 - in head: devel/msgpack math/calc security/gnupg security/gnupg1 sysutils/z Message-ID: <0E681F2E-7A59-4A0C-9010-35D3E0791C5E@adamw.org> In-Reply-To: <20200715073243.GA31163@FreeBSD.org> References: <20200715073243.GA31163@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jul 15, 2020, at 01:32, Alexey Dokuchaev <danfe@freebsd.org> wrote: >=20 > =EF=BB=BFOn Wed, Jul 15, 2020 at 07:28:28AM +0000, Adam Weinberger wrote: >> New Revision: 542249 >> URL: https://svnweb.freebsd.org/changeset/ports/542249 >>=20 >> Log: >> Unmute some build commands >>=20 >> @@ -30,7 +30,7 @@ USE_GCC=3D yes >>=20 >> post-patch: >> # GoogleTest doesn't support C++98 consumers since 1.10.0 >> - @${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt >> + ${REINPLACE_CMD} -e 's/c++98/c++11/' ${WRKSRC}/CMakeLists.txt >=20 > This is not the build, this is patch command. In the ports, patching > traditionally happens silently. >=20 >> post-install: >> - @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ >> + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/calc \ >> ${STAGEDIR}${PREFIX}/lib/lib*.so >=20 > Stripping also typically happens silenty. >=20 >> - @${TOUCH} ${WRKSRC}/doc/*.texi >> + ${TOUCH} ${WRKSRC}/doc/*.texi >=20 > Touching dummy files (cookies) definitely should happen silently. >=20 >> post-install: >> - @${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} >> + ${MV} ${STAGEDIR}${DATADIR}/help*.txt ${STAGEDIR}${DOCSDIR} >=20 > This one is correct. >=20 >> post-install-DOCS-on: >> - @${MKDIR} ${STAGEDIR}${DOCSDIR} >> + ${MKDIR} ${STAGEDIR}${DOCSDIR} >>=20 >> do-install: >> - @${MKDIR} ${STAGEDIR}${DATADIR} >> + ${MKDIR} ${STAGEDIR}${DATADIR} >=20 > We usually mute mkdir's. Please do not "fix" what ain't broken, this > just creates needless repochurn, pessimizes "svn blame" and solves > no real problem, but just makes things less consistent throughout the > ports tree. No. Just because we all drew an arbitrary line in the sand at one point does= not make it viable today. Those distinctions were made a long time ago when= (a) everybody who wanted third-party software had to experience it; (b) end= -users had to trouble-shoot build failures (in which case minimizing output w= as critical); and (c) we wanted the building/installing experience to be cle= an and quiet and simple. Now it is far more useful for ports to show exactly what it=E2=80=99s doing.= As an example, your =E2=80=9Cdefinitely should happen silently=E2=80=9D exa= mple is a case where we do something that explicitly causes the build to reg= enerate something that it wouldn=E2=80=99t normally. =E2=80=9CConsistency=E2=80=9D when each build output is completely different= is not a particularly compelling argument for me. It used to be, but now I=E2= =80=99m much more interested in preserving build output whenever possible. # Adam =E2=80=94 Adam Weinberger adamw@adamw.org https://www.adamw.org=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0E681F2E-7A59-4A0C-9010-35D3E0791C5E>