Date: Fri, 25 Mar 2011 22:56:54 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: "Pedro F. Giffuni" <giffunip@tutopia.com> Cc: freebsd-fs@freebsd.org Subject: Re: kern/152079: [msdosfs] [patch] Small cleanups from the other NetBSD/OpenBSD Message-ID: <20110325205654.GP78089@deviant.kiev.zoral.com.ua> In-Reply-To: <758552.89055.qm@web113514.mail.gq1.yahoo.com> References: <20110325165314.GO78089@deviant.kiev.zoral.com.ua> <758552.89055.qm@web113514.mail.gq1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--fciAcgbhTOkUP7Ni Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 25, 2011 at 11:13:39AM -0700, Pedro F. Giffuni wrote: > Hello; > --- On Fri, 3/25/11, Kostik Belousov <kostikbel@gmail.com> wrote: > ... > > >=9A Fixes NetBSD PR #44661 > > Can you extract the test referenced in the commit message > > ? > Here is the NetBSD link: >=20 > http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/fs/vfs/t_vnops.c.diff?r1=3D= 1.21&r2=3D1.22 >=20 > but I have no idea if it will apply to our testing framework. No, I do not want it in our testing framework. I want to see a standalone test that demonstrates the issue. I think the leak is real, but want to have a way to reproduce it before committing. The diff you pointed out to t_vnops.c does not make much sense to me. >=20 > >=20 > > I think that s/EROFS/EINVAL/ change could and should be > > committed first, and then the (potential) fix for the > > vnode leakage as a separate commit. > > >=20 > It takes some time to get patches committed, so I usually > prefer to submit bigger patches, if I can, in order to save > reviewer's time. EINVAL it trivial, and also it seems to be NOP, because VFS blocks attempts to delete or rename the mount point root directory. For delete, it is explicit check, for rename, the cause is the fact that lookup returns the covered vnode, and you either get a loop or cross-device link error. >=20 > FWIW, I prefer so much bugzilla since permits better patch > handling and obsoleting the diffs that have been applied > already.=20 >=20 >=20 > =20 --fciAcgbhTOkUP7Ni Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk2NAZYACgkQC3+MBN1Mb4gecACdFAc9BUkPxpKKfovTecNgDh58 4KsAn1uDjuf/FpJYW2e7zkAD2gTL+s66 =pvy/ -----END PGP SIGNATURE----- --fciAcgbhTOkUP7Ni--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110325205654.GP78089>