Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 May 2013 17:29:44 -0400
From:      Julian Elischer <julian@freebsd.org>
To:        Julian Elischer <julian@freebsd.org>
Cc:        svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r250700 - in head/sys: conf net netinet6 sys
Message-ID:  <51954FC8.7040502@freebsd.org>
In-Reply-To: <51954C96.3060409@freebsd.org>
References:  <201305161620.r4GGKIFI012296@svn.freebsd.org> <CAJOYFBBdGSz2n0R6e6TrCKsxc-N8nP41WyZ3GWD7EPmva_CSwg@mail.gmail.com> <51954C96.3060409@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/16/13 5:16 PM, Julian Elischer wrote:
> On 5/16/13 3:19 PM, Ed Schouten wrote:
>> Hey Julian,
>>
>> 2013/5/16 Julian Elischer <julian@freebsd.org>:
>>>   #define M_SETFIB(_m, _fib) do 
>>> {                                                \
>>> -       _m->m_flags &= 
>>> ~M_FIB;                                          \
>>> -       _m->m_flags |= (((_fib) << M_FIBSHIFT) & M_FIB);  \
>>> +        KASSERT((_m)->m_flags & M_EXT, ("No FIB on non header 
>>> mbuf")); \
>>> +       ((_m)->m_pkthdr.fibnum) = 
>>> (_fib);                               \
>>>   } while (0)
>> This KASSERT triggers on my box at home. Sorry, but busy right now, so
>> I can't spend too much time debugging this. Right after getting a
>> DHCPACK on bootup, the box panics. Copied by hand:
>
> thanks
> My face is red because while this indicates a bug in someone else's 
> code, I should
> have caught it myself.. but guess what?   I accidentally turned off 
> invariants.. duh!
>
> I will track down the  errant code and fix..

red face....    note the cut-n-paste error above..  M_EXT should be 
M_PKTHDR

see correcting commit

>
> Julian
>
> \
>
>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51954FC8.7040502>