Date: Thu, 7 Feb 2008 10:28:44 GMT From: CyberLeo <cyberleo@cyberleo.net> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/120341: twe pci parity error printf lacks terminating newline Message-ID: <200802071028.m17ASiVU086261@www.freebsd.org> Resent-Message-ID: <200802071040.m17Ae1I3056827@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 120341
>Category: kern
>Synopsis: twe pci parity error printf lacks terminating newline
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 07 10:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: CyberLeo
>Release: RELENG_6_3
>Organization:
CyberLeo.Net
>Environment:
FreeBSD mtumishi.cyberleo.net 6.3-RELEASE FreeBSD 6.3-RELEASE #2: Sat Jan 19 02:11:12 PST 2008 cyberleo@mtumishi.cyberleo.net:/usr/obj/usr/src/sys/MTUMISHI i386
>Description:
twe(4) driver printf for TWE_STATUS_PCI_PARITY_ERROR message lacks terminating newline.
Confirmed in CURRENT and 6x/7x branches.
>How-To-Repeat:
Use a 3ware card, cause a PCI parity error, watch dmesg or console log.
>Fix:
Apply the included patch.
Patch attached with submission follows:
--- sys/dev/twe/twe.c-orig Thu Feb 7 03:35:02 2008
+++ sys/dev/twe/twe.c Thu Feb 7 03:35:22 2008
@@ -1696,7 +1696,7 @@
}
result = 1;
if (status_reg & TWE_STATUS_PCI_PARITY_ERROR) {
- twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present.");
+ twe_printf(sc, "PCI parity error: Reseat card, move card or buggy device present.\n");
twe_clear_pci_parity_error(sc);
}
if (status_reg & TWE_STATUS_PCI_ABORT) {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802071028.m17ASiVU086261>