Date: Wed, 24 Mar 2004 20:12:01 +0100 (CET) From: Melvyn Sopacua <mdev@idg.nl> To: FreeBSD-gnats-submit@FreeBSD.org Cc: MAINTAINER <nork@FreeBSD.org> Subject: ports/64663: killall usage in DarwinStreamingServer shutdown script Message-ID: <20040324191201.9328921E25E@stream.webwereld.nl> Resent-Message-ID: <200403241920.i2OJKIGH000444@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 64663
>Category: ports
>Synopsis: killall usage in DarwinStreamingServer shutdown script
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Mar 24 11:20:17 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Melvyn Sopacua
>Release: FreeBSD 5.2.1-RELEASE-p1 i386
>Organization:
IDG.nl
>Environment:
System: FreeBSD stream.webwereld.nl 5.2.1-RELEASE-p1 FreeBSD 5.2.1-RELEASE-p1 #1: Fri Mar 12 13:09:55 CET 2004 root@nahlia.idg.nl:/usr/obj/usr/src/sys/WEBSERVER_GENII i386
>Description:
The shutdown script uses killall to shutdown DarwinStreamingServer.
However - DarwinStreamingServer is longer than MAXCOMLEN (19) and
therefore killall fails.
There is a pid file as well.
>How-To-Repeat:
Try to stop the server via the rc script.
>Fix:
Index: darwin_streaming_server.sh
===================================================================
RCS file: /home/ncvs/ports/net/DarwinStreamingServer/files/darwin_streaming_server.sh,v
retrieving revision 1.1
diff -u -r1.1 darwin_streaming_server.sh
--- darwin_streaming_server.sh 23 Oct 2002 13:13:23 -0000 1.1
+++ darwin_streaming_server.sh 24 Mar 2004 19:10:23 -0000
@@ -24,7 +24,11 @@
stop)
case ${darwin_streaming_server_enable} in
[Yy][Ee][Ss])
- /usr/bin/killall DarwinStreamingS && echo -n ' DarwinStreamingServer'
+ if [ -f /var/run/DarwinStreamingServer.pid ]; then
+ /usr/bin/kill `cat /var/run/DarwinStreamingServer.pid` && echo -n ' DarwinStreamingServer'
+ else
+ echo -n ' DarwinStreamingServer: no pid file'
+ fi
;;
esac
;;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040324191201.9328921E25E>