Date: Fri, 21 Oct 2016 00:00:47 +0200 From: Jilles Tjoelker <jilles@stack.nl> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r307469 - head/etc Message-ID: <20161020220047.GA68806@stack.nl> In-Reply-To: <CANCZdfoWHcWAc-=9ZuxVFK73BHpvth2Rmuzc8etO=s3A_F1QMQ@mail.gmail.com> References: <201610170407.u9H47D5n033011@repo.freebsd.org> <20161019202656.GA58917@stack.nl> <CANCZdfoWHcWAc-=9ZuxVFK73BHpvth2Rmuzc8etO=s3A_F1QMQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 19, 2016 at 04:45:21PM -0600, Warner Losh wrote:
> What missing quotes? It seemed to work find on the system I brought up...
In ${root_rw_mount#[Yy][Ee][Ss]} with root_rw_mount=YES, the substring
operation results in an empty string, which is removed because there are
no quotes. This makes the test expression invalid.
The result, with /firstboot existing, is two messages "[: =: unexpected
operator" and an attempt to mount / read-only.
> I didn't do the case statement because it would be three extra big
> useless syntactical boogers in the code :)
Fair enough.
> I do like the idea of using checkyesno.
It probably makes sense to change etc/rc.d/root to use checkyesno. This
ensures behaviour with invalid values is exactly the same.
--
Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161020220047.GA68806>