Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Sep 2008 14:10:56 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Sam Leffler <sam@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, Kip Macy <kmacy@freebsd.org>, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/cxgb/ulp/toecore toedev.c src/sys/netinet tcp_offload.c toedev.h
Message-ID:  <200809081410.57357.jhb@freebsd.org>
In-Reply-To: <48BC102C.3080508@freebsd.org>
References:  <200809010531.m815VOf0085178@repoman.freebsd.org> <48BC102C.3080508@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 01 September 2008 11:54:20 am Sam Leffler wrote:
> Kip Macy wrote:
> > kmacy       2008-09-01 05:30:22 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/dev/cxgb/ulp/toecore toedev.c
> >     sys/netinet          tcp_offload.c toedev.h
> >   Log:
> >   SVN rev 182591 on 2008-09-01 05:30:22Z by kmacy
> >
> >   Don't check if an interface can do tcp offload if there are no offload
> > devices registered on the system.
>
> This appears to have an unrelated change as well:
> >  	/*
> >  	 * Look up the route used for the connection to
> >  	 * determine if it uses an interface capable of
> >  	 * offloading the connection.
> >  	 */
> > -	rt = rtalloc1(nam, 1 /*report*/, 0 /*ignflags*/);
> > +	rt = rtalloc1(nam, 0 /*report*/, 0 /*ignflags*/);
> >  	if (rt)
> >  		RT_UNLOCK(rt);
> >  	else
>
> Was that intentional?

Maybe that is the source of the ARP breakage on 7.x?

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809081410.57357.jhb>