Date: Sun, 3 Jun 2007 21:49:46 -0500 From: "Scot Hetzel" <swhetzel@gmail.com> To: "Ion-Mihai Tetcu" <itetcu@freebsd.org> Cc: ports@freebsd.org, Klaus Koch <klaus@sentinel.dyndns.info> Subject: Re: FreeBSD Port: dspam-devel-3.8.0,1 Message-ID: <790a9fff0706031949m7b642d49wa66414bf05c9b852@mail.gmail.com> In-Reply-To: <20070603152358.4a7f06e1@it.buh.tecnik93.com> References: <200706020904.36038.klaus@sentinel.dyndns.info> <200706021457.56718.klaus@sentinel.dyndns.info> <20070602213322.5675cf6d@it.buh.tecnik93.com> <200706031233.52274.klaus@sentinel.dyndns.info> <20070603152358.4a7f06e1@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_12405_17475291.1180925386409 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 6/3/07, Ion-Mihai Tetcu <itetcu@freebsd.org> wrote: > The only thing I can think of for improving this part is to set the > default MySQL version in the port's OPTIONs to the one installed on the > system, if any and default to 50 if no MySQL is installed. Which will > further complicate an already long (664 lines) Makefile with little > added benefit. IMO either there's no MySQL installed - in which case > the port is so friendly that it gives a nice screen for the user to > select the version he wants - or there is a MySQL version installed - > in which case one assumes the admin knows what version he has and > selects it in the OPTIONs screen. (I'm hacking the Makefile for this > but something doesn't work right yet). > There is even an easier solution, and that is to let /usr/ports/Mk/bsd.database.mk do the selection of the MySQL port for you depending on which version is installed on the system. And if none is installed, then use the default version (currently MySQL 5.0). This way there is no need for the WITH_MYSQLxx variables, and you won't have to add a new variable when MySQL 5.2 is released. Your port will automatically support it when bsd.database.mk is updated. Attached for your review is a patch that implements this. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised. ------=_Part_12405_17475291.1180925386409 Content-Type: text/x-diff; name="dspam.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="dspam.patch" X-Attachment-Id: file0 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL25jdnMvcG9ydHMvbWFp bC9kc3BhbS9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42MQpkaWZmIC11IC1yMS42 MSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMTMgTWFyIDIwMDcgMjA6MTE6MTcgLTAwMDAJMS42MQor KysgTWFrZWZpbGUJNCBKdW4gMjAwNyAwMjozNjo1NCAtMDAwMApAQCAtNDksMTUgKzQ5LDEyIEBA CiBPUFRJT05TKz0JQ0xBTUFWX0RFVkVMICJFbmFibGUgY2xhbWF2IHN1cHBvcnQiIG9mZgogT1BU SU9OUys9CUNMQU1BVl9MT0NBTCAiUlVOX0RFUEVORCBvbiBzZWxlY3RlZCBjbGFtYXYiIG9uCiAj Ci1PUFRJT05TKz0JTVlTUUw0MCAiVXNlIE15U1FMIDQuMC54IGFzIGJhY2stZW5kIiBvZmYKLU9Q VElPTlMrPQlNWVNRTDQxICJVc2UgTXlTUUwgNC4xLnggYXMgYmFjay1lbmQiIG9mZgotT1BUSU9O Uys9CU1ZU1FMNTAgIlVzZSBNeVNRTCA1LjAueCBhcyBiYWNrLWVuZCIgb24KLU9QVElPTlMrPQlN WVNRTDUxICJVc2UgTXlTUUwgNS4xLnggYXMgYmFjay1lbmQiIG9mZgorT1BUSU9OUys9CU1ZU1FM ICJVc2UgTXlTUUwgYXMgYmFjay1lbmQiIG9uCiBPUFRJT05TKz0JTVlTUUxfQ09NUFJFU1MgIkNv bXByZXNzIGRzcGFtIDwtLT4gTXlTUUwiIG9mZgogT1BUSU9OUys9CU1ZU1FMX0xPQ0FMICJSVU5f REVQRU5EIG9uIHNlbGVjdGVkIE15U1FMIHNlcnZlciB2ZXIuIiBvZmYKIE9QVElPTlMrPQlQT1NU R1JFU1FMICJVc2UgUG9zdGdyZVNRTCBhcyBiYWNrLWVuZCIgb24KIE9QVElPTlMrPQlQT1NUR1JF U1FMX0xPQ0FMICJSVU5fREVQRU5EIG9uIFBvc3RncmVTUUwgc2VydmVyIiBvZmYKIE9QVElPTlMr PQlPUkFDTEUgIlVzZSBPcmFjbGUgYXMgYmFjay1lbmQgKEJST0tFTikiIG9mZgogT1BUSU9OUys9 CVNRTElURTIgIlVzZSBTUUxpdGUgdjIueCBhcyBiYWNrLWVuZCIgb2ZmCiBPUFRJT05TKz0JU1FM SVRFMyAiVXNlIFNRTGl0ZSB2My54IGFzIGJhY2stZW5kIiBvbgogT1BUSU9OUys9CUhBU0ggIlVz ZSBoYXNoIGRyaXZlciIgb24KQEAgLTI2NSwyMiArMjYyLDcgQEAKIFBMSVNUX1NVQis9CUhBU0g9 IkBjb21tZW50ICIKIC5lbmRpZgogCi0uaWZkZWYoV0lUSF9NWVNRTDQwKQotV0FOVF9NWVNRTF9W RVI9CTQwCi0jUEtHTkFNRVNVRkZJWD0JLW15c3FsNDAKLS5lbGlmZGVmKFdJVEhfTVlTUUw0MSkK LVdBTlRfTVlTUUxfVkVSPQk0MQotI1BLR05BTUVTVUZGSVg9CS1teXNxbDQxCi0uZWxpZm5kZWYo V0lUSE9VVF9NWVNRTDUwKQotV0FOVF9NWVNRTF9WRVI9CTUwCi0jUEtHTkFNRVNVRkZJWD0JLW15 c3FsNTAKLS5lbGlmZGVmKFdJVEhfTVlTUUw1MSkKLVdBTlRfTVlTUUxfVkVSPQk1MQotI1BLR05B TUVTVUZGSVg9CS1teXNxbDUxCi0uZW5kaWYKLQotLmlmIGRlZmluZWQoV0lUSF9NWVNRTDQwKSB8 fCBkZWZpbmVkKFdJVEhfTVlTUUw0MSkgfHwgXAotCSFkZWZpbmVkKFdJVEhPVVRfTVlTUUw1MCkg fHwgZGVmaW5lZChXSVRIX01ZU1FMNTEpCisuaWYgIWRlZmluZWQoV0lUSE9VVF9NWVNRTCkKIFVT RV9NWVNRTD0JeWVzCiBDT05GSUdVUkVfQVJHUys9CS0td2l0aC1teXNxbC1pbmNsdWRlcz0ke0xP Q0FMQkFTRX0vaW5jbHVkZS9teXNxbCBcCiAJCS0td2l0aC1teXNxbC1saWJyYXJpZXM9JHtMT0NB TEJBU0V9L2xpYi9teXNxbApAQCAtMjkwLDcgKzI3MSw3IEBACiBDT05GSUdVUkVfQVJHUys9CS0t ZW5hYmxlLWNsaWVudC1jb21wcmVzc2lvbgogLgllbmRpZgogLglpZiBkZWZpbmVkKFdJVEhfTVlT UUxfTE9DQUwpCi1SVU5fREVQRU5EUys9CW15c3FsLXNlcnZlcj49MDoke1BPUlRTRElSfS9kYXRh YmFzZXMvbXlzcWwke1dBTlRfTVlTUUxfVkVSfS1zZXJ2ZXIKK1JVTl9ERVBFTkRTKz0JbXlzcWwt c2VydmVyPj0wOiR7UE9SVFNESVJ9L2RhdGFiYXNlcy9teXNxbCR7TVlTUUxfVkVSfS1zZXJ2ZXIK IFNVQl9MSVNUKz0JTVlTUUw9bXlzcWwKIC4JZWxzZQogU1VCX0xJU1QrPQlNWVNRTD0KQEAgLTM2 Miw3ICszNDMsNyBAQAogLmVuZGlmCiAKIC5pZmRlZihXSVRIX0VYSU1fTERBKQotLglpZmRlZihX SVRIX01ZU1FMNDApIHx8IChXSVRIX01ZU1FMNDEpCisuCWlmICR7TVlTUUxfVkVSfSA9PSA0MCB8 fCAke01ZU1FMX1ZFUn0gPT0gNDEKIF9FWElNX0VYVD0JLW15c3FsCiAuCWVsaWZkZWYoV0lUSF9Q T1NUR1JFU1FMKQogX0VYSU1fRVhUPQktcG9zdGdyZXNxbApAQCAtNTM3LDEwICs1MTgsNiBAQAog CUAke0VDSE9fQ01EfSAiWW91IG5lZWQgTXlTUUwsIFBvc3RncmVTUUwgb3IgSGFzaCBmb3IgRGFl bW9uIG1vZGUsIGJlY2F1c2UgbXVsdGl0aHJlYWRpbmcgc3VwcG9ydCBpcyBuZWVkZWQiCiAJQCR7 RkFMU0V9CiAuZW5kaWYKLS5pZiAoIGRlZmluZWQoV0lUSF9NWVNRTDQwKSAmJiBkZWZpbmVkKFdJ VEhfTVlTUUw0MSkgJiYgIWRlZmluZWQoV0lUSE9VVF9NWVNRTDUwKSAmJiBkZWZpbmVkKFdJVEhf TVlTUUw1MSkpCi0JQCR7RUNIT19DTUR9ICJZb3UgY2FuIGNvbXBpbGUgd2l0aCBvbmx5IG9uZSBN eVNRTCB2ZXJzaW9uIGRyaXZlci4iCi0JQCR7RkFMU0V9Ci0uZW5kaWYKIC5pZiBkZWZpbmVkKFdJ VEhfTERBUCkgJiYgISggZGVmaW5lZChVU0VfTVlTUUwpIHx8IFwKIAkhZGVmaW5lZChXSVRIT1VU X1BPU1RHUkVTUUwpIHx8IGRlZmluZWQoVVNFX1NRTElURSkgKQogCUAke0VDSE9fQ01EfSAiWW91 IG5lZWQgTXlTUUwsIFBvc3RncmVzIG9yIFNRTElURSBmb3IgTERBUC4iCg== ------=_Part_12405_17475291.1180925386409--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?790a9fff0706031949m7b642d49wa66414bf05c9b852>