Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Jun 2013 12:26:31 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@freebsd.org
Subject:   ports/179199: [PATCH] net/pchar: Fix docs, comply with OptionsNG
Message-ID:  <20130602102634.C230CBC2@hub.freebsd.org>
Resent-Message-ID: <201306021030.r52AU1to002890@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179199
>Category:       ports
>Synopsis:       [PATCH] net/pchar: Fix docs, comply with OptionsNG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 02 10:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Fix docs
- Comply with OptionsNG
- Remove pkg-plist
- Make portlint happy
- Cleanup Makefile

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
>Fix:

--- pchar-1.5.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net/pchar/Makefile ./Makefile
--- /usr/ports/net/pchar/Makefile	2013-01-14 17:56:35.000000000 +0100
+++ ./Makefile	2013-04-01 00:13:48.000000000 +0200
@@ -12,16 +12,20 @@
 COMMENT=	Sandia Internet path characterization tool
 
 GNU_CONFIGURE=	yes
+CONFIGURE_ARGS=	--with-pcap
+
+PLIST_FILES=	sbin/${PORTNAME}
+
 MAN8=		pchar.8
 
-.include <bsd.port.pre.mk>
+PORTDOCS=	CHANGES FAQ README
 
-CONFIGURE_ARGS= --with-pcap
+.include <bsd.port.options.mk>
 
-.if !defined(NOPORTDOCS)
 post-install:
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-	cd ${WRKSRC} ; ${INSTALL_DATA} README CHANGES FAQ ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
diff -ruN --exclude=CVS /usr/ports/net/pchar/pkg-plist ./pkg-plist
--- /usr/ports/net/pchar/pkg-plist	2013-01-14 17:56:35.000000000 +0100
+++ ./pkg-plist	1970-01-01 01:00:00.000000000 +0100
@@ -1,6 +0,0 @@
-@comment $FreeBSD: head/net/pchar/pkg-plist 300897 2012-07-14 14:29:18Z beat $
-sbin/pchar
-%%PORTDOCS%%%%DOCSDIR%%/CHANGES
-%%PORTDOCS%%%%DOCSDIR%%/FAQ
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
--- pchar-1.5.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130602102634.C230CBC2>