Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Aug 2000 16:23:33 -0700
From:      Marcel Moolenaar <marcel@cup.hp.com>
To:        Doug White <dwhite@resnet.uoregon.edu>
Cc:        Marcel Moolenaar <marcel@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/compat/linux linux_socket.c
Message-ID:  <39A85175.148F900D@cup.hp.com>
References:  <Pine.BSF.4.21.0008261211250.40564-100000@resnet.uoregon.edu>

next in thread | previous in thread | raw e-mail | index | archive | help
Doug White wrote:
> 
> On Fri, 25 Aug 2000, Marcel Moolenaar wrote:
> 
> > marcel      2000/08/25 22:12:18 PDT
> >
> >   Modified files:
> >     sys/compat/linux     linux_socket.c
> 
> Um, isn't this a no-no?  You're not supposed to re-style existing files;
> you generated a 700-line diff for no functional change.

I have functional changes to commit as well. It's definitely a no-no to
mix that with white-space fixes. If I can't resist myself to change
style as well while I'm coding, I'd better get the style issue out of my
way.

-- 
Marcel Moolenaar
  mail: marcel@cup.hp.com / marcel@FreeBSD.org
  tel:  (408) 447-4222


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39A85175.148F900D>