Date: Tue, 18 Sep 2018 14:53:04 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r480028 - head/multimedia/libdv Message-ID: <201809181453.w8IEr4x4071289@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste (src committer) Date: Tue Sep 18 14:53:04 2018 New Revision: 480028 URL: https://svnweb.freebsd.org/changeset/ports/480028 Log: multimedia/libdv: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_32 against symbol: dv_vlc_class_index_mask in readonly segment; recompile object files with -fPIC >>> defined in .libs/vlc.o >>> referenced by .libs/vlc_x86.o:(.text+0xF) This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. PR: 214864 Approved by: bapt Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17220 Modified: head/multimedia/libdv/Makefile Modified: head/multimedia/libdv/Makefile ============================================================================== --- head/multimedia/libdv/Makefile Tue Sep 18 14:50:27 2018 (r480027) +++ head/multimedia/libdv/Makefile Tue Sep 18 14:53:04 2018 (r480028) @@ -21,6 +21,7 @@ LDFLAGS+= -L${LOCALBASE}/lib INSTALL_TARGET= install-strip USES= jpeg libtool pathfix pkgconfig USE_LDCONFIG= yes +LDFLAGS_i386= -Wl,-znotext DOCS= AUTHORS COPYING COPYRIGHT ChangeLog NEWS README \ README.dvconnect README.encoder TODO
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809181453.w8IEr4x4071289>