Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Nov 2017 11:16:18 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r325274 - head/sys/dev/hwpmc
Message-ID:  <201711011116.vA1BGIiV068052@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Nov  1 11:16:18 2017
New Revision: 325274
URL: https://svnweb.freebsd.org/changeset/base/325274

Log:
  There is no use for dropping Giant in the pmc syscall.
  
  Reviewed by:	markj
  Tested by:	pho
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week
  X-Differential revision:	https://reviews.freebsd.org/D12882

Modified:
  head/sys/dev/hwpmc/hwpmc_mod.c

Modified: head/sys/dev/hwpmc/hwpmc_mod.c
==============================================================================
--- head/sys/dev/hwpmc/hwpmc_mod.c	Wed Nov  1 11:05:47 2017	(r325273)
+++ head/sys/dev/hwpmc/hwpmc_mod.c	Wed Nov  1 11:16:18 2017	(r325274)
@@ -2860,8 +2860,6 @@ pmc_syscall_handler(struct thread *td, void *syscall_a
 
 	PMC_GET_SX_XLOCK(ENOSYS);
 
-	DROP_GIANT();
-
 	is_sx_downgraded = 0;
 	is_sx_locked = 1;
 
@@ -4033,8 +4031,6 @@ pmc_syscall_handler(struct thread *td, void *syscall_a
 
 	if (error)
 		atomic_add_int(&pmc_stats.pm_syscall_errors, 1);
-
-	PICKUP_GIANT();
 
 	return (error);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711011116.vA1BGIiV068052>