Date: Fri, 5 Nov 2010 16:57:32 GMT From: Kris Moore <kmoore@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/151968: src: usr.sbin/pc-sysinstall - Fix/improve debug log generation Message-ID: <201011051657.oA5GvWo1003258@www.freebsd.org> Resent-Message-ID: <201011051700.oA5H0IJo076685@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 151968
>Category: misc
>Synopsis: src: usr.sbin/pc-sysinstall - Fix/improve debug log generation
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Nov 05 17:00:18 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Kris Moore
>Release: 9.0-Current
>Organization:
iXsystems
>Environment:
9.0-Current
>Description:
This patch fixes an issue including a disk-listing when creating a debug log, and also removes passwords from the log file for the security minded.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- src.o/usr.sbin/pc-sysinstall/backend-query/send-logs.sh 2010-11-05 12:05:56.951853683 -0400
+++ src/usr.sbin/pc-sysinstall/backend-query/send-logs.sh 2010-11-05 12:53:03.762601405 -0400
@@ -50,7 +50,7 @@
then
echo "" >>${TMPLOG}
echo "# PC-SYSINSTALL CFG " >>${TMPLOG}
- cat /tmp/sys-install.cfg >> ${TMPLOG}
+ cat /tmp/sys-install.cfg | grep -v 'rootPass' | grep -v 'userPass' >> ${TMPLOG}
fi
# Save dmesg output
@@ -59,7 +59,7 @@
dmesg >> ${TMPLOG}
# Get gpart info on all disks
-for i in `${PROGDIR}/pc-sysinstall disk-list | cut -d ':' -f 1`
+for i in `pc-sysinstall disk-list | cut -d ':' -f 1`
do
echo "" >>${TMPLOG}
echo "# DISK INFO $i " >>${TMPLOG}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011051657.oA5GvWo1003258>