Date: Wed, 4 Aug 2004 20:03:00 +0200 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: Dan Cojocar <dan.cojocar@gmail.com> Subject: Re: problems with altq Message-ID: <200408042003.07356.max@love2party.net> In-Reply-To: <20040804130530.GA78973@stud.fit.vutbr.cz> References: <20040804125640.GA78633@stud.fit.vutbr.cz> <20040804130530.GA78973@stud.fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-02=_bTSEB15I2x32NcA
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Wednesday 04 August 2004 15:05, Divacky Roman wrote:
> struct pf_altq *altq, *a;
>
> if (pa->ticket !=3D ticket_altqs_inactive) {
> error =3D EBUSY;
> break;
> }
> altq =3D pool_get(&pf_altq_pl, PR_NOWAIT);
> ^^^^^^^^^^
> shouldnt this be initalized to NULL? at least its not nice to have it
> uninitalized...
hum?
$ cd /usr/src/sys/contrib/pf/net && grep pf_altq_pl *
<...>
pf_ioctl.c: pf_state_pl =3D pf_altq_pl =3D pf_pooladdr_pl =3D NULL;
pf_ioctl.c: UMA_DESTROY(pf_altq_pl);
pf_ioctl.c: UMA_CREATE(pf_altq_pl, struct pf_altq, "pfaltqpl=
");
<...>
Or what are you thinking about?
Just like Dan Cojocar said in his reply, I can't reproduce your problem=20
here :-\
> On Wed, Aug 04, 2004 at 02:56:40PM +0200, Divacky Roman wrote:
> > I am getting this
> > pfctl: DIOCADDALTQ: Cannot allocate memory
> > if I try to enable altq on pf configured as
> >
> > altq on $ext_if bandwidth 256Kb cbq queue { ssh_i web other}
> > queue ssh_i bandwidth 25% cbq(borrow red)
> > queue web bandwidth 25% cbq(borrow red)
> > queue other bandwidth 50% cbq(borrow default red)
> >
> >
> > without that "red" it works ok...
Now that is strange as it makes no difference in the DIOCADDALTQ call path=
=20
whether you use RED or not. Might it be possible that you really are short =
on=20
(kernel) memory?
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--Boundary-02=_bTSEB15I2x32NcA
Content-Type: application/pgp-signature
Content-Description: signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBBESTbXyyEoT62BG0RAluXAJ0RGCwC9FL4AS7LbH7FDoqpFRX79ACfSw+y
TZw/LBY0AyEx1Ctw23iy1sg=
=njby
-----END PGP SIGNATURE-----
--Boundary-02=_bTSEB15I2x32NcA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408042003.07356.max>