Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Aug 2020 22:50:22 -0400
From:      Alexander Motin <mav@FreeBSD.org>
To:        koobs@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r364038 - head/sys/dev/pci
Message-ID:  <2da6aeeb-fa7e-c30a-da13-e8220f188081@FreeBSD.org>
In-Reply-To: <1113e4f6-3bb9-3944-74d1-b467d71c8dd8@FreeBSD.org>
References:  <202008071840.077Iev6Q019339@repo.freebsd.org> <1113e4f6-3bb9-3944-74d1-b467d71c8dd8@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07.08.2020 21:14, Kubilay Kocak wrote:
> On 8/08/2020 4:40 am, Alexander Motin wrote:
>> Author: mav
>> Date: Fri Aug  7 18:40:56 2020
>> New Revision: 364038
>> URL: https://svnweb.freebsd.org/changeset/base/364038
>>
>> Log:
>>    Enable hw.pci.enable_aspm tunable by default.
>>       While effects on power saving is only a guess, effects on
>> hot-plug are
>>    clearly visible.  Lets try to enable it and see what happen.
>>       MFC after:    3 months
>>
>> Modified:
>>    head/sys/dev/pci/pci.c
>>
>> Modified: head/sys/dev/pci/pci.c
>> ==============================================================================
>>
>> --- head/sys/dev/pci/pci.c    Fri Aug  7 18:38:10 2020    (r364037)
>> +++ head/sys/dev/pci/pci.c    Fri Aug  7 18:40:56 2020    (r364038)
>> @@ -408,7 +408,7 @@ static int pci_enable_ari = 1;
>>   SYSCTL_INT(_hw_pci, OID_AUTO, enable_ari, CTLFLAG_RDTUN,
>> &pci_enable_ari,
>>       0, "Enable support for PCIe Alternative RID Interpretation");
>>   -int pci_enable_aspm;
>> +int pci_enable_aspm = 1;
>>   SYSCTL_INT(_hw_pci, OID_AUTO, enable_aspm, CTLFLAG_RDTUN,
>> &pci_enable_aspm,
>>       0, "Enable support for PCIe Active State Power Management");
>>   _______________________________________________
>> svn-src-head@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>>
> 
> relnotes: Yes?

If you say so.  But since there is no real functionality behind it other
then a small lie to ACPI, I am not sure.

-- 
Alexander Motin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2da6aeeb-fa7e-c30a-da13-e8220f188081>