Date: Fri, 20 Dec 2013 09:05:42 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r259642 - head/sys/netinet Message-ID: <CAJ-VmokzW26%2BvLWr-RN5EFdBx1C6oS0WxONpGbD68BqXaVjzjg@mail.gmail.com> In-Reply-To: <20131220084419.GK71033@FreeBSD.org> References: <201312200741.rBK7f3tL038123@svn.freebsd.org> <20131220084419.GK71033@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 December 2013 00:44, Gleb Smirnoff <glebius@freebsd.org> wrote: > I didn't get to review of actual patch, but IMO it would be better > just to remove the code, not ifdef 0 it. The code ifdefed has zero > probability to be enabled in its current form. If we ever fix it, code > would look very different. > > No reason to do followup commit, that was just me muttering. I figured it would be nicer in the short term to #if 0 it out whilst some other discussions went on, just to make it really obvious in the short term where the check was done. It's quite possible I'll eventually just trim it entirely out. Thanks, -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokzW26%2BvLWr-RN5EFdBx1C6oS0WxONpGbD68BqXaVjzjg>