Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 Apr 2017 17:31:58 +0000 (UTC)
From:      Conrad Meyer <cem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316584 - head/sys/fs/smbfs
Message-ID:  <201704061731.v36HVwfZ072434@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cem
Date: Thu Apr  6 17:31:58 2017
New Revision: 316584
URL: https://svnweb.freebsd.org/changeset/base/316584

Log:
  smbfs: Fix an indentation level
  
  Based on the change in r242386, it seems clear that scred was intended to
  be released in all paths at exit.
  
  No functional change.  This line's indent was just the result of a bad copy
  paste from the previous free() in an early exit path.
  
  Reported by:	PVS-Studio
  Sponsored by:	Dell EMC Isilon

Modified:
  head/sys/fs/smbfs/smbfs_vnops.c

Modified: head/sys/fs/smbfs/smbfs_vnops.c
==============================================================================
--- head/sys/fs/smbfs/smbfs_vnops.c	Thu Apr  6 17:16:41 2017	(r316583)
+++ head/sys/fs/smbfs/smbfs_vnops.c	Thu Apr  6 17:31:58 2017	(r316584)
@@ -280,7 +280,7 @@ smbfs_getattr(ap)
 	smbfs_attr_cachelookup(vp, va);
 	if (np->n_flag & NOPEN)
 		np->n_size = oldsize;
-		smbfs_free_scred(scred);
+	smbfs_free_scred(scred);
 	return 0;
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704061731.v36HVwfZ072434>