Date: Mon, 9 Mar 2009 15:08:41 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: ian j hart <ianjhart@ntlworld.com> Cc: Sascha Holzleiter <sascha@holzleiter.name>, freebsd-stable@freebsd.org, Jung-uk Kim <jkim@freebsd.org> Subject: Re: FreeBSD 7.1 Breaks re and rl Network Interface Drivers Message-ID: <20090309060841.GH5039@michelle.cdnetworks.co.kr> In-Reply-To: <200903081705.12523.ianjhart@ntlworld.com> References: <8dfae1c10901070639x67945324jeeecfcac647d7976@mail.gmail.com> <200903071717.57915.ianjhart@ntlworld.com> <20090308023642.GB1531@michelle.cdnetworks.co.kr> <200903081705.12523.ianjhart@ntlworld.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 08, 2009 at 05:05:12PM +0000, ian j hart wrote: > On Sunday 08 March 2009 02:36:42 Pyun YongHyeon wrote: > > On Sat, Mar 07, 2009 at 05:17:57PM +0000, ian j hart wrote: > > > On Tuesday 20 January 2009 02:45:19 Pyun YongHyeon wrote: > > > > On Mon, Jan 19, 2009 at 06:33:46PM -0500, Jung-uk Kim wrote: > > > > > On Monday 19 January 2009 04:33 pm, Jung-uk Kim wrote: > > > > > > I found something interesting. I have another RTL8169SC that > > > > > > works perfectly fine without the patch. The hardware revision is > > > > > > 0x18000000. After reading Linux driver (drivers/net/r8169c), I > > > > > > realised they use different masks for hardware revisions. With > > > > > > their logic, non-working chip seems to be 0x98000000 (8110SCe) > > > > > > while working chip seems to be 0x18000000 (8110SCd) with > > > > > > 0xfc800000. FYI... > > > > > > > > > > Now armed with the information, I made it work without reverting > > > > > memory mapped I/O. :-) > > > > > > > > > > http://people.freebsd.org/~jkim/re/re.current2.diff > > > > > http://people.freebsd.org/~jkim/re/re.stable2.diff > > > > > > > > I like the patch. Since only RTL8169 family uses mask 0xfc800000 > > > > it would be even better we can limit checking scope for RTL8169SC > > > > by comparing PCI device id. I don't know what other side effect > > > > would happen if the mask 0xfc800000 would be used on 8101/8168 > > > > controllers. > > > > If the patch works on RTL8169SC would you commit the patch? > > > > I'd like to see multiple commits separated by each enhancements > > > > as the patch contains several fixes which are not directly related > > > > with the issue. > > > > > > Where are we on this? > > > > > > I have a headless firewall box which is not happy with 7.1-RELEASE. I've > > > upgraded to 7.1-STABLE as of yesterday and now I'm getting 'PHY read > > > failed' errors, although the network did come up, which was an > > > improvement. > > > > > > Is there a patch I can try? > > > > > > http://www.jetway.com.tw/jw/ipcboard_view.asp?productid=174&proname=AD3RT > > >LAN-G > > > > > > re0: <RealTek 8169SC/8110SC Single-chip Gigabit Ethernet> port > > > 0xf200-0xf2ff mem 0xfdfff000-0xfdfff0ff irq 18 at device 9.0 on pci0 re0: > > > Chip rev. 0x18000000 > > > re0: MAC rev. 0x00000000 > > > re0: Ethernet address: 00:30:18:ae:1a:1b > > > re0: [FILTER] > > > re1: <RealTek 8169SC/8110SC Single-chip Gigabit Ethernet> port > > > 0xf000-0xf0ff mem 0xfdffd000-0xfdffd0ff irq 19 at device 11.0 on pci0 > > > re1: Chip rev. 0x18000000 > > > re1: MAC rev. 0x00000000 > > > re1: Ethernet address: 00:30:18:ae:1a:1c > > > re1: [FILTER] > > > re2: <RealTek 8169SC/8110SC Single-chip Gigabit Ethernet> port > > > 0xec00-0xecff mem 0xfdffc000-0xfdffc0ff irq 16 at device 12.0 on pci0 > > > re2: Chip rev. 0x18000000 > > > re2: MAC rev. 0x00000000 > > > re2: Ethernet address: 00:30:18:ae:1a:1d > > > re2: [FILTER] > > > > > > re0@pci0:0:9:0: class=0x020000 card=0x10ec16f3 chip=0x816710ec rev=0x10 > > > hdr=0x00 re1@pci0:0:11:0: class=0x020000 card=0x10ec16f3 > > > chip=0x816710ec rev=0x10 hdr=0x00 re2@pci0:0:12:0: class=0x020000 > > > card=0x10ec16f3 chip=0x816710ec rev=0x10 hdr=0x00 > > > > Have you tried re(4) in HEAD? > > I had one report that re(4) in HEAD still does not fix the issue so > > I posted a possible workaround for that. Unfortunately he didn't > > report back so I don't know whether it was right workaround or not. > > If re(4) in HEAD does not fix the issue, would you try attached > > patch and let me know how it goes? > > Firstly IANAKH, my expertise in this area stops after "make kernel". > > I updated > > /usr/src/sys/dev/re/if_re.c > /usr/src/sys/pci/if_rlreg.h > > to HEAD > And after updating to HEAD did you apply my patch? > I still get "PHY read failed" with and without the patch. > That's odd. Another user who has the same controller reports the fix fixed the issue. I also committed the patch to HEAD so would you give it spin again (without applying any patches)?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090309060841.GH5039>