Date: Mon, 2 Dec 2013 16:56:42 +0000 (UTC) From: David Naylor <dbn@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r335512 - head/Mk Message-ID: <201312021656.rB2Gugnj086621@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dbn Date: Mon Dec 2 16:56:42 2013 New Revision: 335512 URL: http://svnweb.freebsd.org/changeset/ports/335512 Log: Add sanity check for LIB_DEPENDS and RUN_DEPENDS. Ports does not support relative paths in ${TYPE}_DEPENDS and actually breaks the dependency registration with pkgng. This occurs in ACTUAL_PACKAGE_DEPENDS where ${PORTSDIR} is stripped from the dependencies' directory and uses the rest of the string as the package origin. pkg(8) then fails to detect package origins with relative paths. Approved by: portmgr (bapt) Modified: head/Mk/bsd.sanity.mk Modified: head/Mk/bsd.sanity.mk ============================================================================== --- head/Mk/bsd.sanity.mk Mon Dec 2 16:53:01 2013 (r335511) +++ head/Mk/bsd.sanity.mk Mon Dec 2 16:56:42 2013 (r335512) @@ -51,6 +51,14 @@ DEV_ERROR+= "USE_KDELIBS_VER is unsuppor DEV_ERROR+= "USE_QT_VER is unsupported" .endif +.if !empty(LIB_DEPENDS:M*/../*) +DEV_ERROR+= "LIB_DEPENDS contains unsupported relative path to dependency" +.endif + +.if !empty(RUN_DEPENDS:M*/../*) +DEV_ERROR+= "RUN_DEPENDS contains unsupported relative path to dependency" +.endif + .if defined(USE_DISPLAY) DEV_WARNING+= "USE_DISPLAY is deprecated, please use USES=display" .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312021656.rB2Gugnj086621>