Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jul 2021 11:59:13 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 6581afbb3335 - stable/12 - pf tests: make killstate:match more robust
Message-ID:  <202107301159.16UBxDhL050619@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=6581afbb3335a620ba5f219011ccc898ea2a32ba

commit 6581afbb3335a620ba5f219011ccc898ea2a32ba
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-07-27 13:31:00 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-07-30 11:57:02 +0000

    pf tests: make killstate:match more robust
    
    Only lists the states relevant to the connection we're killing.
    Sometimes there are IPv6 related states (due to the usual IPv6
    background traffic of router solicitations, DAD, ...) that causes us to
    think we failed to kill the state, which in turn caused the test to fail
    intermittently.
    
    MFC after:      3 days
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit 4e860bd5da1423aac9aed0541c484ebf9c1d1621)
---
 tests/sys/netpfil/pf/killstate.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/sys/netpfil/pf/killstate.sh b/tests/sys/netpfil/pf/killstate.sh
index 2b77ea189294..adf229945911 100644
--- a/tests/sys/netpfil/pf/killstate.sh
+++ b/tests/sys/netpfil/pf/killstate.sh
@@ -354,7 +354,7 @@ match_body()
 	wait_for_state alcatraz 192.0.2.1
 
 	# Expect two states
-	states=$(jexec alcatraz pfctl -s s | wc -l)
+	states=$(jexec alcatraz pfctl -s s | grep 192.0.2.1 | wc -l)
 	if [ $states -ne 2 ] ;
 	then
 		atf_fail "Expected two states, found $states"
@@ -362,7 +362,7 @@ match_body()
 
 	# If we don't kill the matching NAT state one should be left
 	jexec alcatraz pfctl -k 192.0.2.1
-	states=$(jexec alcatraz pfctl -s s | wc -l)
+	states=$(jexec alcatraz pfctl -s s | grep 192.0.2.1 | wc -l)
 	if [ $states -ne 1 ] ;
 	then
 		atf_fail "Expected one states, found $states"
@@ -376,7 +376,7 @@ match_body()
 
 	# Kill matching states, expect all of them to be gone
 	jexec alcatraz pfctl -M -k 192.0.2.1
-	states=$(jexec alcatraz pfctl -s s | wc -l)
+	states=$(jexec alcatraz pfctl -s s | grep 192.0.2.1 | wc -l)
 	if [ $states -ne 0 ] ;
 	then
 		atf_fail "Expected zero states, found $states"



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107301159.16UBxDhL050619>