Date: Tue, 25 Aug 2009 17:20:02 GMT From: "Green, Paul" <Paul.Green@stratus.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/137307: [libc] [patch] Enhance strptime(3) to support %U and %W Message-ID: <200908251720.n7PHK2XJ023549@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/137307; it has been noted by GNATS. From: "Green, Paul" <Paul.Green@stratus.com> To: <bug-followup@FreeBSD.org> Cc: "Green, Paul" <Paul.Green@stratus.com> Subject: Re: kern/137307: [libc] [patch] Enhance strptime(3) to support %U and %W Date: Tue, 25 Aug 2009 12:33:21 -0400 This is a multi-part message in MIME format. ------_=_NextPart_001_01CA25A1.C230115A Content-Type: multipart/alternative; boundary="----_=_NextPart_002_01CA25A1.C230115A" ------_=_NextPart_002_01CA25A1.C230115A Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This is a follow-up to problem report kern/137307 regarding proposed changes to the strptime function. Shortly after I submitted the report, I discovered that I had submitted the old version of the t_strptime.c test program. The version that I submitted is coded with the assumption that the tm_yday member of "struct tm" is 1-origin. In fact, it is 0-origin. The modified code for strptime.c that I submitted is correct; only the test case was wrong. This new version of t_strptime.c also adds some guards so that the tests for %U and %W are not normally compiled; you must change the value of the ALLOW_UW_TESTS macro from 0 to 1 to run them. This makes it easier to run the tests on a system that doesn't implement the new features. I have attached a uni-diff that corrects t_strptime.c. I apologize for my mistake. Thanks PG <<t_strptime.diff.txt>>=20 ------_=_NextPart_002_01CA25A1.C230115A Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> <HTML> <HEAD> <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; = charset=3Dus-ascii"> <META NAME=3D"Generator" CONTENT=3D"MS Exchange Server version = 6.5.7654.12"> <TITLE>Re: kern/137307: [libc] [patch] Enhance strptime(3) to support %U = and %W</TITLE> </HEAD> <BODY> <!-- Converted from text/rtf format --> <P><FONT SIZE=3D2 FACE=3D"Arial">This is a follow-up to problem report = kern/137307 regarding proposed changes to the strptime function.</FONT> </P> <P><FONT SIZE=3D2 FACE=3D"Arial">Shortly after I submitted the report, I = discovered that I had submitted the old version of the t_strptime.c test = program. The version that I submitted is coded with the assumption = that the tm_yday member of "struct tm" is 1-origin. In = fact, it is 0-origin. The modified code for strptime.c that I = submitted is correct; only the test case was wrong.</FONT></P> <P><FONT SIZE=3D2 FACE=3D"Arial">This new version of t_strptime.c also = adds some guards so that the tests for %U and %W are not normally = compiled; you must change the value of the ALLOW_UW_TESTS macro from 0 = to 1 to run them. This makes it easier to run the tests on a = system that doesn't implement the new features.</FONT></P> <P><FONT SIZE=3D2 FACE=3D"Arial">I have attached a uni-diff that = corrects t_strptime.c.</FONT> </P> <P><FONT SIZE=3D2 FACE=3D"Arial">I apologize for my mistake.</FONT> </P> <P><FONT SIZE=3D2 FACE=3D"Tahoma">Thanks</FONT> <BR><FONT SIZE=3D2 FACE=3D"Tahoma">PG</FONT> <BR><FONT FACE=3D"Arial" SIZE=3D2 COLOR=3D"#000000"> = <<t_strptime.diff.txt>> </FONT> </P> </BODY> </HTML> ------_=_NextPart_002_01CA25A1.C230115A-- ------_=_NextPart_001_01CA25A1.C230115A Content-Type: text/plain; name="t_strptime.diff.txt" Content-Transfer-Encoding: base64 Content-Description: t_strptime.diff.txt Content-Disposition: attachment; filename="t_strptime.diff.txt" LS0tIHRfc3RycHRpbWUuYmFkLmMJMjAwOS0wNy0zMCAxNjoyODoyMC4wMDAwMDAwMDAgLTA0MDAK KysrIHRfc3RycHRpbWUuYwkyMDA5LTA4LTI1IDEyOjE5OjIxLjAwMDAwMDAwMCAtMDQwMApAQCAt MTEsNiArMTEsMTAgQEAKICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KICNpbmNsdWRlICJ0aW1lLmgi CiAKKyNkZWZpbmUgQUxMT1dfVVdfVEVTVFMgMAorCitjaGFyICpzdHJwdGltZSAoY29uc3QgY2hh ciAqLCBjb25zdCBjaGFyICosIHN0cnVjdCB0bSAqKTsKKwogc3RhdGljIGludCBmYWlsdXJlcyA9 IDA7CiAKIHN0YXRpYyB2b2lkIGV4cGxhaW4gKGNoYXIgKnRpdGxlLCBjaGFyICpmbXQsIGNoYXIg KnNyYykKQEAgLTE2NCw2ICsxNjgsOCBAQAogCXByaW50ZiAoIlxuIik7CiB9CiAKKyNpZiBBTExP V19VV19URVNUUworCiAvKiBTcGVjaWFsIHRlc3QgZm9yIHRoZSAlVSBmb3JtYXQgc3RyaW5nLiAg VHJ5IHRvIGNvbnZlcnQKICAgICIyMDA5IDIxIiwgd2hpY2ggaXMgNS8zMS8yMDA5ICovCiAKQEAg LTE3OSwxNCArMTg1LDE0IEBACiAJICAgIHIudG1fbWRheSA9PSAzMSAmJgogCSAgICByLnRtX3ll YXIgPT0gMTA5ICYmCiAJICAgIHIudG1fd2RheSA9PSAwICYmCi0JICAgIHIudG1feWRheSA9PSAx NTEpCi0JCXByaW50ZiAoIlJlc3VsdDogICBTdW5kYXkgTWF5IDMxIDIwMDksIHlkYXkgMTUxIFt3 ZWVrIDIxXSAob2spXG4iKTsKKwkgICAgci50bV95ZGF5ID09IDE1MCkKKwkJcHJpbnRmICgiUmVz dWx0OiAgIFN1bmRheSBNYXkgMzEgMjAwOSwgeWRheSAxNTAgW3dlZWsgMjFdIChvaylcbiIpOwog CWVsc2UKIAl7CiAJCWZhaWx1cmVzKys7CiAJCXByaW50ZiAoIlJlc3VsdDogICBmYWlsZWQuICUw MmQvJTAyZC8lMDRkIHdkYXk9JWQgeWRheT0lZFxuIiwKIAkJCXIudG1fbW9uKzEsIHIudG1fbWRh eSwgci50bV95ZWFyKzE5MDAsIHIudG1fd2RheSwgci50bV95ZGF5KTsKLQkJcHJpbnRmICgiRXhw ZWN0ZWQgICAgICAgICAgMDUvMzEvMjAwOSB3ZGF5PTAgeWRheT0xNTFcbiIpOworCQlwcmludGYg KCJFeHBlY3RlZCAgICAgICAgICAwNS8zMS8yMDA5IHdkYXk9MCB5ZGF5PTE1MFxuIik7CiAJfQog CXByaW50ZiAoIlxuIik7CiB9CkBAIC0yMDYsMTQgKzIxMiwxNCBAQAogCSAgICByLnRtX21kYXkg PT0gMSAmJgogCSAgICByLnRtX3llYXIgPT0gMTA5ICYmCiAJICAgIHIudG1fd2RheSA9PSAxICYm Ci0JICAgIHIudG1feWRheSA9PSAxNTIpCi0JCXByaW50ZiAoIlJlc3VsdDogICBNb25kYXkgSnVu ZSAxIDIwMDksIHlkYXkgMTUyIFt3ZWVrIDIxXSAob2spXG4iKTsKKwkgICAgci50bV95ZGF5ID09 IDE1MSkKKwkJcHJpbnRmICgiUmVzdWx0OiAgIE1vbmRheSBKdW5lIDEgMjAwOSwgeWRheSAxNTEg W3dlZWsgMjFdIChvaylcbiIpOwogCWVsc2UKIAl7CiAJCWZhaWx1cmVzKys7CiAJCXByaW50ZiAo IlJlc3VsdDogICBmYWlsZWQuICUwMmQvJTAyZC8lMDRkIHdkYXk9JWQgeWRheT0lZFxuIiwKIAkJ CXIudG1fbW9uKzEsIHIudG1fbWRheSwgci50bV95ZWFyKzE5MDAsIHIudG1fd2RheSwgci50bV95 ZGF5KTsKLQkJcHJpbnRmICgiRXhwZWN0ZWQ6ICAgICAgICAgMDYvMDEvMjAwOSB3ZGF5PTEgeWRh eT0xNTJcbiIpOworCQlwcmludGYgKCJFeHBlY3RlZDogICAgICAgICAwNi8wMS8yMDA5IHdkYXk9 MSB5ZGF5PTE1MVxuIik7CiAJfQogCXByaW50ZiAoIlxuIik7CiB9CkBAIC0yNTMsNyArMjU5LDcg QEAKIAlmb3IgKHllYXI9MTk5ODsgeWVhcjwyMDA1OyB5ZWFyKyspCiAJewogCQltZGF5ID0gZmly c3Rfc3VuZGF5W3llYXItMTk5OF07Ci0JCXlkYXkgPSBtZGF5OworCQl5ZGF5ID0gbWRheSAtIDE7 CiAJCXByaW50ZiAoIlRoZSBmaXJzdCBTdW5kYXkgb2YgJTRkIGlzIEphbiAlZC5cbiIsIHllYXIs IG1kYXkpOwogCiAJCWZvciAodz0xOyB3PDU0OyB3KyspCkBAIC0yNjYsNyArMjcyLDcgQEAKIAkJ CWlmICh3ID09IDUzICYmIG1vbiA9PSAwKQogCQkJewogCQkJCXlyID0geWVhciArIDE7Ci0JCQkJ eWRheSA9IG1kYXk7CisJCQkJeWRheSA9IG1kYXkgLSAxOwogCQkJfQogCQkJZWxzZSB5ciA9IHll YXI7CiAKQEAgLTI5MSw3ICsyOTcsNyBAQAogCXByaW50ZiAoIlxuIik7CiB9CiAKLS8qIFNwZWNp YWwgdGVzdCBmb3IgdGhlICVXIGZvcm1hdCBzdHJpbmcuICAqLworI2VuZGlmIC8qIEFMTE9XX1VX X1RFU1RTICovCiAKIGludCBtYWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiB7CkBAIC0zMzIs MTMgKzMzOCwxOSBAQAogICAgICB0cnk1ICgiVGltZSBvZiBkYXkgSDpNIiwgIiVSIiwgIjIzOjU5 Iik7CiAgICAgIHRyeTEgKCJTZWNvbmQgbnVtYmVyIiwgICAiJVMiLCAiNTkiLCAgICAgICBvZmZz ZXRvZiAoc3RydWN0IHRtLCB0bV9zZWMpLCA1OSk7CiAgICAgIHRyeTYgKCJUaW1lIG9mIGRheSBI Ok06UyIsICIlVCIsICIyMzo1OTo1OSIpOworI2lmIEFMTE9XX1VXX1RFU1RTCiAgICAgIHRyeTcg KCJXZWVrIG51bWJlciBTdW49MCIsICIlWSAlVSIsICIyMDA5IDIyIik7CisjZW5kaWYKICAgICAg dHJ5MSAoIldlZWsgZGF5IG51bWJlciIsICIldyIsICI0IiwgICAgICAgIG9mZnNldG9mIChzdHJ1 Y3QgdG0sIHRtX3dkYXkpLCA0KTsKKyNpZiBBTExPV19VV19URVNUUwogICAgICB0cnk4ICgiV2Vl ayBudW1iZXIgTW9uPTAiLCAiJVkgJVciLCAiMjAwOSAyMiIpOworI2VuZGlmCiAgICAgIHRyeTEg KCJZZWFyIGluIGNlbnR1cnkiLCAgIiV5IiwgICI5IiwgICAgICBvZmZzZXRvZiAoc3RydWN0IHRt LCB0bV95ZWFyKSwgMTA5KTsKICAgICAgdHJ5MSAoIlllYXIgaW4gY2VudHVyeSIsICAiJVkiLCAg IjIwMDkiLCAgIG9mZnNldG9mIChzdHJ1Y3QgdG0sIHRtX3llYXIpLCAxMDkpOwogCisjaWYgQUxM T1dfVVdfVEVTVFMKICAgICAgdHJ5VSAoIlUgY29udmVyc2lvbiIsICIlWSAlVSIsICJyYW5nZSIp OworI2VuZGlmCiAKICAgICAgaWYgKGZhaWx1cmVzKQogICAgICAgICAgIHByaW50ZiAoIiVkIHRl c3RzIGZhaWxlZC5cbiIsIGZhaWx1cmVzKTsK ------_=_NextPart_001_01CA25A1.C230115A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908251720.n7PHK2XJ023549>