Date: Tue, 16 May 2006 00:30:25 GMT From: Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/97327: [MAINTAINER] mail/exilog: fix rc.d stuff Message-ID: <200605160030.k4G0UPqc031794@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/97327; it has been noted by GNATS. From: Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org> To: Larry Rosenman <ler@lerctr.org> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/97327: [MAINTAINER] mail/exilog: fix rc.d stuff Date: Tue, 16 May 2006 03:26:43 +0300 --Sig_yH68e=p7oKQt1zh5fv409/F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 15 May 2006 18:41:57 -0500 Larry Rosenman <ler@lerctr.org> wrote: > USE_RC_SUBR=3D exilog.sh > PLIST_SUB+=3D AGENT=3D"" > +.if (${OSVERSION} >=3D 700007 || (${OSVERSION} < 700000 && ${OSVERSION} = >=3D 600101)) > + RCSCRIPT=3Dexilog > +.else > + RCSCRIPT=3Dexilog.sh > +.endif > +PLIST_SUB+=3D RCSCRIPT=3D${RCSCRIPT} > .endif This is not needed, USE_RC_SUBR takes care of it and installs one rc.d script, depending of OSVERSION. > =20 > PLIST_SUB+=3D EXILOGDIR=3D"${EXILOGDIR:S,^${PREFIX}/,,}" > @@ -76,9 +84,6 @@ > @${CHMOD} 0600 ${PREFIX}/etc/exilog.conf-dist > @${CHOWN} ${WWWOWN}:${WWWGRP} ${PREFIX}/etc/exilog.conf-dist > @${CP} ${FILESDIR}/htaccess ${EXILOGDIR}/.htaccess > -.if !defined(NO_AGENT) > - @${INSTALL_SCRIPT} ${WRKDIR}/exilog.sh ${PREFIX}/etc/rc.d > -.endif Personally I disagree with this behavior, if the server doesn't crash w/o the deleted files (think of portupgrade'ing), YMMV. > +%%AGENT%%etc/rc.d/%%RCSCRIPT%% This is not need either. USE_RC_SUBR takes care of it. I would also change NO_AGENT --> WITH[OUT]_AGENT=20 Current Makefile lacks some "()": .ifndef WITHOUT_WWWDIR Also it could use OPTIONS. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" BOFH excuse #253: We've run out of licenses --Sig_yH68e=p7oKQt1zh5fv409/F Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEaRxDBX6fi0k6KXsRAoSiAKCC5oCkMkI3VSMioG8IEYcxKhxt/ACeM6EM PRlAz6UYy6M25iOC5FnH7x8= =AVlm -----END PGP SIGNATURE----- --Sig_yH68e=p7oKQt1zh5fv409/F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605160030.k4G0UPqc031794>