Date: Thu, 15 Jan 2015 20:14:30 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, sbruno@freebsd.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <20150115171430.GO15484@FreeBSD.org> In-Reply-To: <54B7E566.8050601@selasky.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54B7E287.80406@FreeBSD.org> <54B7E566.8050601@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hans, On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote: H> > Eh, I have not reviewed this at all. (I still plan to though.) H> H> The "Reviewed by" was simply a C&P of the review list in from the H> Differential Revision. When you mention it should probably simply have said: H> H> Reviewed by: sbruno @ H> H> Due to the meaning of "Reviewed by" in commit messages. Sorry. H> H> BTW: Nice if people respond quickly or remove themselves from the H> differential reviews if they don't plan to do any reviews. I'd dare to say that such important change simply cannot be committed with a thorough review from at least two people very confident in this area. Look at r247777. This is the way it should be done. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150115171430.GO15484>