Date: Fri, 7 Jan 2000 18:20:02 -0800 (PST) From: Ade Lovett <ade@lovett.com> To: freebsd-ports@FreeBSD.org Subject: Re: ports/15951: port submission Message-ID: <200001080220.SAA44874@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/15951; it has been noted by GNATS.
From: Ade Lovett <ade@lovett.com>
To: janssen@rendo.dekooi.nl
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/15951: port submission
Date: Fri, 7 Jan 2000 20:13:37 -0600
On Thu, Jan 06, 2000 at 05:31:11PM +0100, Sander.Janssen@rendo.dekooi.nl wrote:
>
> >Number: 15951
> >Category: ports
> >Synopsis: port submission
>
> [mp3rename]
I've taken a look at this, and there seem to be a number of problems
with the port as it stands..
0. looks like you missed an EOL at the end of the one line PLIST,
the sharball fails to extract unless one is manually added in.
1. trying to fetch the port results in:
fetch: empty reply from www.rendo.dekooi.nl
this can be fixed by adding:
FETCH_BEFORE_ARGS= -b
to the Makefile (or get a proper http server :)
2. the tarball extracts itself as ${WRKDIR}/mp3rename0.4
(note the missing '-'), requiring:
WRKSRC= ${WRKDIR}/mp3rename0.4
to be added to the Makefile (or the tarball to be fixed,
since you control it).
3. The actual Makefile in ${WRKSRC} overrides CC, CFLAGS, INSTALL,
doesn't use ${PREFIX} for installation, nor is the binary
stripped.
4. A manpage would be nice, but failing that, installing the
README into ${PREFIX}/share/doc/mp3rename/... (with appropriate
caveats if NOPORTDOCS is defined)
All these issues are covered in the Porting section of the handbook,
which you can find at:
http://www.FreeBSD.org/handbook/porting.html
or /usr/share/doc/handbook/porting.html if you have the doc set
installed on your machine.
If you can fix all of these (about 10 minutes work), and resubmit,
then I'm sure it'll get committed.
-aDe
--
Ade Lovett, Austin, TX.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001080220.SAA44874>