Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Feb 2006 02:02:11 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 90909 for review
Message-ID:  <200602020202.k1222BiZ026131@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=90909

Change 90909 by rwatson@rwatson_peppercorn on 2006/02/02 02:01:11

	Stub comments about what audit for AUE_SENDFILE will need to
	capture.  This also suppresses the conversion warning for event
	364.
	
	Note: this may require some work, as up until now we've needed only
	to audit a single file descriptor per system call.  sendfile() uses
	two, so will require expanding our in-kernel audit record.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#3 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_bsm.c#3 (text+ko) ====

@@ -439,6 +439,19 @@
 		}
 		break;
 
+	case AUE_SENDFILE:
+		/*
+		 * XXXRW: While sendfile() is effectively a combination of
+		 * read() and write(), it is useful to audit if only because
+		 * it performs IPC/network I/O.  We will need to eventually
+		 * audit the following information to be complete:
+		 *
+		 * - socket information
+		 * - file descriptor information for two file descriptors
+		 * - file information
+		 */
+		break;
+
 	case AUE_ACCT:
 		if (ARG_IS_VALID(kar, ARG_UPATH1)) {
 			UPATH1_VNODE1_TOKENS;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602020202.k1222BiZ026131>