Date: Mon, 5 Nov 2018 10:28:03 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Mark Linimon <linimon@lonesome.com>, Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484041 - head/devel/heimdall Message-ID: <20181105102802.GA34032@FreeBSD.org> In-Reply-To: <20181105101623.hb2q56kavr4hbp4h@atuin.in.mat.cc> References: <201811041345.wA4DjCGN025777@repo.freebsd.org> <20181104151315.GA61162@FreeBSD.org> <20181104172918.GA21261@lonesome.com> <20181105060132.GA4050@FreeBSD.org> <20181105101623.hb2q56kavr4hbp4h@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 05, 2018 at 11:16:23AM +0100, Mathieu Arnold wrote: > On Mon, Nov 05, 2018 at 06:01:32AM +0000, Alexey Dokuchaev wrote: > > On Sun, Nov 04, 2018 at 05:29:18PM +0000, Mark Linimon wrote: > > > On Sun, Nov 04, 2018 at 03:13:15PM +0000, Alexey Dokuchaev wrote: > > > > I don't understand, why not just fix the code by removing offending > > > > part: > > > > > > portsjail% grep -v "#" ../analysis/clang6_regressions.work | wc -l > > > 261 > > > > > > Fixing 261 ports is more than one person can do IMVVHO. > > > > Okay, but I'm talking about one particular port (which is maintained, > > so one might expect that maintainer has some knowledge of the code) > > and I've attached a patch. I believe it is quite doable by one person > > in this very case. :-) > > Once again, you fail to understand that it is not the job of portmgr to > fix all the broken things, it is to curate the ports tree. I understand that Mathieu. > If we find a simple fix, like here, we do that My point exactly; I didn't imply that someone(tm) should go down the entire logstash and relentlessly try to fix the code no matter what. Good that we agree. This, like you've correctly put, was a simple, easy to find fix (committed in r484179 FWIW). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181105102802.GA34032>