Date: Sat, 6 Jan 2001 16:14:27 -0800 From: Alfred Perlstein <bright@wintelcom.net> To: Bosko Milekic <bmilekic@technokratis.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/musycc musycc.c Message-ID: <20010106161427.G15744@fw.wintelcom.net> In-Reply-To: <005001c07839$40f06820$25cbca18@jehovah>; from bmilekic@technokratis.com on Sat, Jan 06, 2001 at 06:34:46PM -0500 References: <200101062044.f06Kiex42615@freefall.freebsd.org> <20010106132943.E15744@fw.wintelcom.net> <005001c07839$40f06820$25cbca18@jehovah>
next in thread | previous in thread | raw e-mail | index | archive | help
* Bosko Milekic <bmilekic@technokratis.com> [010106 15:33] wrote: > > I find this incredibly dumb. You're just wasting a check that need not be > made. I know when I have to free m and when not to, it's dumb to have to > check it again in errfree. It's Poul's call, however. You have an exceptional condition, it reduces the amount of code someone reading must digest and it should reduce the amount of code the processor needs to put in the I cache. There is also a lot of code that already does this: sosend(), soreceive(), soclose(). What you're doing is giving a place to jump to further along in case any other error conditions come up. One other question, is since so much code does this (get a header and attach an mbuf cluster) why not have a generic all-or-nothing macro for this? -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010106161427.G15744>